Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: pkg/analysis_server/lib/src/services/correction/assist_internal.dart

Issue 1217593006: Quick Assist for converting field formal parameters into normal parameters and initializers. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Tweak for untyped fields. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/correction/assist_internal.dart
diff --git a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart
index 5d03c839b2c3bd7d3b0b4f8516c917d42133e880..d9eb0a494c8f0e14e965c2b2656e97ebb63c8054 100644
--- a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart
+++ b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart
@@ -87,6 +87,7 @@ class AssistProcessor {
_addProposal_convertToIsNot_onIs();
_addProposal_convertToIsNot_onNot();
_addProposal_convertToIsNotEmpty();
+ _addProposal_convertToNormalParameter();
_addProposal_encapsulateField();
_addProposal_exchangeOperands();
_addProposal_importAddShow();
@@ -673,6 +674,38 @@ class AssistProcessor {
_addAssist(DartAssistKind.CONVERT_INTO_IS_NOT_EMPTY, []);
}
+ void _addProposal_convertToNormalParameter() {
+ if (node is SimpleIdentifier &&
+ node.parent is FieldFormalParameter &&
+ node.parent.parent is FormalParameterList &&
+ node.parent.parent.parent is ConstructorDeclaration) {
+ ConstructorDeclaration constructor = node.parent.parent.parent;
+ FormalParameterList parameterList = node.parent.parent;
+ FieldFormalParameter parameter = node.parent;
+ ParameterElement parameterElement = parameter.element;
+ String name = (node as SimpleIdentifier).name;
+ // prepare type
+ DartType type = parameterElement.type;
+ Set<LibraryElement> librariesToImport = new Set<LibraryElement>();
+ String typeCode = utils.getTypeSource(type, librariesToImport);
+ // replace parameter
+ if (type.isDynamic) {
+ _addReplaceEdit(rangeNode(parameter), name);
+ } else {
+ _addReplaceEdit(rangeNode(parameter), '$typeCode $name');
+ }
+ // add field initializer
+ List<ConstructorInitializer> initializers = constructor.initializers;
+ if (initializers.isEmpty) {
+ _addInsertEdit(parameterList.end, ' : $name = $name');
+ } else {
+ _addInsertEdit(initializers.last.end, ', $name = $name');
+ }
+ // add proposal
+ _addAssist(DartAssistKind.CONVERT_TO_NORMAL_PARAMETER, []);
+ }
+ }
+
void _addProposal_encapsulateField() {
// find FieldDeclaration
FieldDeclaration fieldDeclaraton =

Powered by Google App Engine
This is Rietveld 408576698