Move nativeInfo encoding into NativeGenerator.

Move nativeInfo encoding into NativeGenerator.

R=herhut@google.com

Committed: https://github.com/dart-lang/sdk/commit/8d0b368669d40e55288209d4712ff0c33cd15d69

[floitsch, 2015-07-06 13:08:17]

floitsch@google.com changed reviewers:
+ herhut@google.com

[floitsch, 2015-07-06 13:08:18]

https://codereview.chromium.org/1215463006/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/native_generator.dart (right):

https://codereview.chromium.org/1215463006/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/native_generator.dart:85: jsAst.Expression
encodeNativeInfo(Class cls) {
copy/paste except that it returns the encoded result instead of storing it in
the class.

https://codereview.chromium.org/1215463006/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/native_generator.dart:149: jsAst.Statement
buildNativeInfoHandler(
verbatim copy/paste.

[herhut, 2015-07-06 13:16:54]

lgtm w/ comments

https://codereview.chromium.org/1215463006/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/native_generator.dart (right):

https://codereview.chromium.org/1215463006/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/native_generator.dart:85: jsAst.Expression
encodeNativeInfo(Class cls) {
Why is this not static like the others? NativeGenerator seems not to have any
state...

https://codereview.chromium.org/1215463006/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/native_generator.dart:149: jsAst.Statement
buildNativeInfoHandler(
Same here...

https://codereview.chromium.org/1215463006/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/native_generator.dart:156:
subclassReadGenerator(js('subclasses[i]', []));
indentation...

[floitsch, 2015-07-06 16:04:53]

https://codereview.chromium.org/1215463006/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/native_generator.dart (right):

https://codereview.chromium.org/1215463006/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/native_generator.dart:85: jsAst.Expression
encodeNativeInfo(Class cls) {
On 2015/07/06 13:16:54, herhut wrote:
> Why is this not static like the others? NativeGenerator seems not to have any
> state...

Done.

https://codereview.chromium.org/1215463006/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/native_generator.dart:149: jsAst.Statement
buildNativeInfoHandler(
On 2015/07/06 13:16:54, herhut wrote:
> Same here...

Done.

https://codereview.chromium.org/1215463006/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/native_generator.dart:156:
subclassReadGenerator(js('subclasses[i]', []));
On 2015/07/06 13:16:53, herhut wrote:
> indentation...

Done.

[floitsch, 2015-07-06 16:10:30]

Committed patchset #2 (id:20001) manually as
8d0b368669d40e55288209d4712ff0c33cd15d69 (presubmit successful).