pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart - Issue 1215463006: Move nativeInfo encoding into NativeGenerator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart

Issue 1215463006: Move nativeInfo encoding into NativeGenerator. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address comments and fix null-pointer error. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart

index 47bd9ff225923a23943e8f905b951421c796c26e..3a7ab5705f3fabffa7339d48994e87556f0da7a5 100644

--- a/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart

@@ -275,8 +275,9 @@ class ClassEmitter extends CodeEmitterHelper {

}

void emitNativeInfo(Class cls, ClassBuilder builder) {

- if (cls.nativeInfo != null) {

- builder.addPropertyByName(namer.nativeSpecProperty, cls.nativeInfo);

+ jsAst.Expression nativeInfo = NativeGenerator.encodeNativeInfo(cls);

+ if (nativeInfo != null) {

+ builder.addPropertyByName(namer.nativeSpecProperty, nativeInfo);

}