Issue 12154006: Remove Sink and move CollectionSink to async.

Issue 12154006: Remove Sink and move CollectionSink to async. (Closed)

Created:
7 years, 10 months ago by floitsch

Modified:
7 years, 10 months ago

Reviewers:
Bob Nystrom, Lasse Reichstein Nielsen, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Remove Sink and move CollectionSink to async. Committed: https://code.google.com/p/dart/source/detail?r=18063 Reverted: https://code.google.com/p/dart/source/detail?r=18067 Committed: https://code.google.com/p/dart/source/detail?r=18144

Patch Set 4 : Remove usage of Sink from pub. #

Created: 7 years, 10 months ago

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -84 lines)
M	pkg/http/lib/src/multipart_request.dart	View	1 chunk	+1 line, -1 line	0 comments
M	pkg/http/lib/src/streamed_request.dart	View	1 chunk	+1 line, -1 line	0 comments
M	sdk/lib/_internal/compiler/compiler.dart	View	2 chunks	+3 lines, -2 lines	0 comments
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 chunk	+3 lines, -1 line	0 comments
M	sdk/lib/_internal/compiler/implementation/dart2js.dart	View	3 chunks	+5 lines, -3 lines	0 comments
M	sdk/lib/_internal/compiler/implementation/dart2jslib.dart	View	1 chunk	+1 line, -0 lines	0 comments
M	sdk/lib/async/async.dart	View	1 chunk	+1 line, -0 lines	0 comments
M	sdk/lib/async/async_sources.gypi	View	1 chunk	+1 line, -0 lines	0 comments
A +	sdk/lib/async/collection_sink.dart	View	2 chunks	+17 lines, -20 lines	0 comments
M	sdk/lib/async/stream.dart	View	2 chunks	+3 lines, -3 lines	0 comments
M	sdk/lib/core/core.dart	View	1 chunk	+0 lines, -1 line	0 comments
M	sdk/lib/core/corelib_sources.gypi	View	1 chunk	+0 lines, -1 line	0 comments
D	sdk/lib/core/sink.dart	View	1 chunk	+0 lines, -49 lines	0 comments
M	tests/lib/async/event_helper.dart	View	1 chunk	+1 line, -1 line	0 comments
M	utils/pub/log.dart	View	1 chunk	+1 line, -1 line	0 comments

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

floitsch

Once I get your ok, I will add Peter and Bob to review their changes. ...

7 years, 10 months ago (2013-02-01 17:00:41 UTC) #1

Lasse Reichstein Nielsen

LGTM! https://codereview.chromium.org/12154006/diff/1/sdk/lib/_internal/compiler/implementation/compiler.dart File sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/12154006/diff/1/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode1118 sdk/lib/_internal/compiler/implementation/compiler.dart:1118: void signalError(AsyncError error) {} Consider throwing the error.

7 years, 10 months ago (2013-02-04 13:21:10 UTC) #2

ahe

LGTM, but I no longer think Sink is a good fit for the compiler API. ...

7 years, 10 months ago (2013-02-04 15:27:30 UTC) #4

Bob Nystrom

7 years, 10 months ago (2013-02-04 20:45:51 UTC) #7

Assuming the pub tests pass, of course, the log.dart change LGTM.

Expand Messages | Collapse Messages