Remove Sink and move CollectionSink to async.

Remove Sink and move CollectionSink to async.

Committed: https://code.google.com/p/dart/source/detail?r=18063
Reverted: https://code.google.com/p/dart/source/detail?r=18067

Committed: https://code.google.com/p/dart/source/detail?r=18144

[floitsch, 2013-02-01 17:00:41]

Once I get your ok, I will add Peter and Bob to review their changes.

Note: CollectionSink currently exposes the collection. Couldn't change that, as
pub depends on it right now.

[Lasse Reichstein Nielsen, 2013-02-04 13:21:10]

LGTM!

https://codereview.chromium.org/12154006/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/12154006/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/compiler.dart:1118: void
signalError(AsyncError error) {}
Consider throwing the error.

[ahe, 2013-02-04 15:27:30]

LGTM, but I no longer think Sink is a good fit for the compiler API.

https://codereview.chromium.org/12154006/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/12154006/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/compiler.dart:1118: void
signalError(AsyncError error) {}
The error should be thrown. You should *never* ignore an error.

But what is this AsyncError business about? Where I have seen it in use, it
gives horrible stack traces, so I think it is a misfeature.

Also, I don't understand what this method is doing here. I'm looking for a
simple interface that lets me abstract a string buffer or a stream, but I'm
beginning to doubt that sinks fit the bill. I should probably stop using this
interface altogether. I don't understand why I would ever tell a StringBuffer or
a Stream that an error occurred, so this is not making any sense to me at all.

https://codereview.chromium.org/12154006/diff/1/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/12154006/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:219: {void onError(AsyncError error),
The argument onError is being ignored.

[Bob Nystrom, 2013-02-04 18:57:45]

pkg/http stuff LGTM!

[floitsch, 2013-02-04 19:39:42]

@Bob: please check that the last change is ok.

[Bob Nystrom, 2013-02-04 20:45:51]

Assuming the pub tests pass, of course, the log.dart change LGTM.