Remove Sink and move CollectionSink to async.

sdk/lib/_internal/compiler/implementation/compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js;
 
 /**
  * If true, print a warning for each method that was resolved, but not
  * compiled.
  */
@@ skipping 1090 matching lines @@
   if (condition is Function){
     condition = condition();
   }
   if (spannable == null || !condition) {
     throw new SpannableAssertionFailure(spannable, message);
   }
   return true;
 }
 
 /// A sink that drains into /dev/null.
-class NullSink extends Sink<String> {
+class NullSink extends StreamSink<String> {
   final String name;
 
   NullSink(this.name);
 
   add(String value) {}
 
+  void signalError(AsyncError error) {}

[Lasse Reichstein Nielsen, 2013/02/04 13:21:10]

Consider throwing the error.

[ahe, 2013/02/04 15:27:30]

The error should be thrown. You should *never* ignore an error.

But what is this AsyncError business about? Where I have seen it in use, it
gives horrible stack traces, so I think it is a misfeature.

Also, I don't understand what this method is doing here. I'm looking for a
simple interface that lets me abstract a string buffer or a stream, but I'm
beginning to doubt that sinks fit the bill. I should probably stop using this
interface altogether. I don't understand why I would ever tell a StringBuffer or
a Stream that an error occurred, so this is not making any sense to me at all.

+
   void close() {}
 
   toString() => name;
 
   /// Convenience method for getting an [api.CompilerOutputProvider].
   static NullSink outputProvider(String name, String extension) {
     return new NullSink('$name.$extension');
   }
 }