Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1214123003: dart2js cps: Ensure JSArray is emitted when we see a type cast. (Closed)

Created:
5 years, 5 months ago by asgerf
Modified:
5 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Ensure JSArray is emitted when we see a type cast. This is a workaround to resolve an issue that is affecting a lot of tests. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/61f47e73844eee381bf30c31d91a425ed5b68175

Patch Set 1 #

Patch Set 2 : Remove a bad comment #

Patch Set 3 : Update output in test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -167 lines) Patch
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 2 chunks +5 lines, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 5 chunks +0 lines, -55 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_control_flow_test.dart View 1 2 1 chunk +2 lines, -2 lines 1 comment Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 2 chunks +0 lines, -7 lines 0 comments Download
M tests/corelib/corelib.status View 2 chunks +0 lines, -19 lines 0 comments Download
M tests/language/language_dart2js.status View 8 chunks +0 lines, -81 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
asgerf
5 years, 5 months ago (2015-07-03 11:31:37 UTC) #2
asgerf
https://codereview.chromium.org/1214123003/diff/40001/tests/compiler/dart2js/js_backend_cps_ir_control_flow_test.dart File tests/compiler/dart2js/js_backend_cps_ir_control_flow_test.dart (right): https://codereview.chromium.org/1214123003/diff/40001/tests/compiler/dart2js/js_backend_cps_ir_control_flow_test.dart#newcode64 tests/compiler/dart2js/js_backend_cps_ir_control_flow_test.dart:64: break L2; Reason for change: Labels are currently numbered ...
5 years, 5 months ago (2015-07-03 12:00:35 UTC) #3
floitsch
LGTM.
5 years, 5 months ago (2015-07-03 12:04:34 UTC) #4
asgerf
5 years, 5 months ago (2015-07-03 12:32:07 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
61f47e73844eee381bf30c31d91a425ed5b68175 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698