Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1214123003: dart2js cps: Ensure JSArray is emitted when we see a type cast. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Update output in test Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index 8f795fffddabc5fd61acdae48180a414daaaaeab..14471733eaaf67c9c9dcfc02a835cc1248f3b5dd 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -205,7 +205,6 @@ class CodeGenerator extends tree_ir.StatementVisitor
if (node.constant != null) return giveup(node);
registry.registerInstantiatedType(node.type);
- Selector selector = node.selector;
FunctionElement target = node.target;
List<js.Expression> arguments = visitExpressionList(node.arguments);
return buildStaticInvoke(target, arguments);
@@ -326,6 +325,11 @@ class CodeGenerator extends tree_ir.StatementVisitor
return js.js(r'!#.immutable$list', <js.Expression>[value]);
}
+ // The helper we use needs the JSArray class to exist, but for some
+ // reason the helper does not cause this dependency to be registered.
+ // TODO(asgerf): Most programs need List anyway, but we should fix this.
+ registry.registerInstantiatedClass(glue.listClass);
+
// We use one of the two helpers:
//
// checkSubtype(value, $isT, typeArgs, $asT)
« no previous file with comments | « no previous file | tests/co19/co19-dart2js.status » ('j') | tests/compiler/dart2js/js_backend_cps_ir_control_flow_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698