Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1213833002: Use a FunctionSignature in CallStructure.signatureApplies (Closed)

Created:
5 years, 6 months ago by Johnni Winther
Modified:
5 years, 6 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use a FunctionSignature in CallStructure.signatureApplies BUG= R=ajohnsen@google.com Committed: https://github.com/dart-lang/sdk/commit/4dced50c3872a3bf932dc51752983d9a5ff08d59

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -25 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 1 3 chunks +7 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +12 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 6 months ago (2015-06-26 12:03:57 UTC) #2
Anders Johnsen
LGTM! Thank you! https://codereview.chromium.org/1213833002/diff/1/pkg/compiler/lib/src/compile_time_constants.dart File pkg/compiler/lib/src/compile_time_constants.dart (right): https://codereview.chromium.org/1213833002/diff/1/pkg/compiler/lib/src/compile_time_constants.dart#newcode792 pkg/compiler/lib/src/compile_time_constants.dart:792: Take out function signature here FunctionSignature ...
5 years, 6 months ago (2015-06-26 12:14:18 UTC) #3
Johnni Winther
https://codereview.chromium.org/1213833002/diff/1/pkg/compiler/lib/src/compile_time_constants.dart File pkg/compiler/lib/src/compile_time_constants.dart (right): https://codereview.chromium.org/1213833002/diff/1/pkg/compiler/lib/src/compile_time_constants.dart#newcode792 pkg/compiler/lib/src/compile_time_constants.dart:792: On 2015/06/26 12:14:18, Anders Johnsen wrote: > Take out ...
5 years, 6 months ago (2015-06-26 12:50:23 UTC) #4
Johnni Winther
5 years, 6 months ago (2015-06-26 12:53:09 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4dced50c3872a3bf932dc51752983d9a5ff08d59 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698