Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: pkg/compiler/lib/src/resolution/send_resolver.dart

Issue 1213833002: Use a FunctionSignature in CallStructure.signatureApplies (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolution/members.dart ('k') | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/send_resolver.dart
diff --git a/pkg/compiler/lib/src/resolution/send_resolver.dart b/pkg/compiler/lib/src/resolution/send_resolver.dart
index fa8cacc84a854af5b1aa865542c45346a041c58a..d3f4e61a0de559b90d27e64d3d9d8df4771f6b1b 100644
--- a/pkg/compiler/lib/src/resolution/send_resolver.dart
+++ b/pkg/compiler/lib/src/resolution/send_resolver.dart
@@ -333,7 +333,9 @@ abstract class SendResolverMixin {
case AccessKind.SUPER_METHOD:
case AccessKind.TOPLEVEL_METHOD:
// TODO(johnniwinther): Should local function also be handled here?
- if (!selector.callStructure.signatureApplies(semantics.element)) {
+ FunctionElement function = semantics.element;
+ FunctionSignature signature = function.functionSignature;
+ if (!selector.callStructure.signatureApplies(signature)) {
return new IncompatibleInvokeStructure(semantics, selector);
}
break;
@@ -586,7 +588,7 @@ abstract class SendResolverMixin {
type,
effectiveTargetSemantics);
} else {
- if (!callStructure.signatureApplies(constructor)) {
+ if (!callStructure.signatureApplies(constructor.functionSignature)) {
return new ConstructorAccessSemantics(
ConstructorAccessKind.INCOMPATIBLE,
constructor,
« no previous file with comments | « pkg/compiler/lib/src/resolution/members.dart ('k') | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698