Fix runtimeType.toString for tear-offs.

Fix runtimeType.toString for tear-offs.

Tear-offs are constructed by building a fresh constructor on the fly. However, that constructor is unnamed and didn't have the 'builtin$cls' property set. As such, the runtime-type system was unable to extract a good name and wasn't able to provide a good 'toString' for it. With this CL the constructor has a good 'name' set.

Also removes the 'builtin$cls' property that was a duplicate of 'name'. Whenever we defined a new Dart class, we added a 'builtin$cls' property on the constructor which was a duplicate of the name. This was necessary, because IE doesn't store the function name on the constructor. However, there we can just assign the 'name' field, and don't need to introduce a new field-name ('builtin$cls'). As such, we can always use the 'name' property.

R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/87a7ca0720f066c51c6f8884bb93b50183aaabe7

[floitsch, 2015-06-26 21:50:00]

floitsch@google.com changed reviewers:
+ sra@google.com

[sra1, 2015-06-26 23:10:10]

lgtm but please expand description to say what is being fixed, perhaps a before
& after example.

https://codereview.chromium.org/1213033002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/1213033002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:1186: if (typeof
constructor.name != 'string') {
Use double quotes in JS for consistency with generated code.

https://codereview.chromium.org/1213033002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/1213033002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1041: if (typeof
#constructorName.name != 'string') {
ditto double quotw

https://codereview.chromium.org/1213033002/diff/1/tests/language/runtime_type...
File tests/language/runtime_type2_test.dart (right):

https://codereview.chromium.org/1213033002/diff/1/tests/language/runtime_type...
tests/language/runtime_type2_test.dart:17: runtimeStringFoo != "" &&
runtimeStringFoo != "undefined");
Can this be strengthened to expect a short name or a specific long name?

[floitsch, 2015-07-01 17:00:15]

https://codereview.chromium.org/1213033002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/1213033002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:1186: if (typeof
constructor.name != 'string') {
On 2015/06/26 23:10:09, sra1 wrote:
> Use double quotes in JS for consistency with generated code.

done. also in other places.

https://codereview.chromium.org/1213033002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/1213033002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1041: if (typeof
#constructorName.name != 'string') {
On 2015/06/26 23:10:09, sra1 wrote:
> ditto double quotw

Done.

https://codereview.chromium.org/1213033002/diff/1/tests/language/runtime_type...
File tests/language/runtime_type2_test.dart (right):

https://codereview.chromium.org/1213033002/diff/1/tests/language/runtime_type...
tests/language/runtime_type2_test.dart:17: runtimeStringFoo != "" &&
runtimeStringFoo != "undefined");
On 2015/06/26 23:10:09, sra1 wrote:
> Can this be strengthened to expect a short name or a specific long name?

It's hard:
- the VM and dart2js disagree.
- after minification the name becomes unpredictable.

[sra1, 2015-07-01 17:12:59]

https://codereview.chromium.org/1213033002/diff/1/tests/language/runtime_type...
File tests/language/runtime_type2_test.dart (right):

https://codereview.chromium.org/1213033002/diff/1/tests/language/runtime_type...
tests/language/runtime_type2_test.dart:17: runtimeStringFoo != "" &&
runtimeStringFoo != "undefined");
On 2015/07/01 17:00:15, floitsch wrote:
> On 2015/06/26 23:10:09, sra1 wrote:
> > Can this be strengthened to expect a short name or a specific long name?
> 
> It's hard:
> - the VM and dart2js disagree.
> - after minification the name becomes unpredictable.

runtimeStringFoo.contains(vmstring) ||
runtimeStringFoo.contains(dart2jsString) ||
runtimeStringFoo.matches(regex for dart2js with 3 or fewer characters)

[sra1, 2015-07-01 19:15:49]

lgtm

[floitsch, 2015-07-02 08:59:36]

Committed patchset #3 (id:40001) manually as
87a7ca0720f066c51c6f8884bb93b50183aaabe7 (presubmit successful).