Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

Issue 1213033002: Fix runtimeType.toString for tear-offs. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Improved test. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.new_js_emitter.emitter; 5 library dart2js.new_js_emitter.emitter;
6 6
7 import 'package:js_runtime/shared/embedded_names.dart' show 7 import 'package:js_runtime/shared/embedded_names.dart' show
8 JsBuiltin, 8 JsBuiltin,
9 METADATA, 9 METADATA,
10 TYPES; 10 TYPES;
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 125
126 @override 126 @override
127 js.Expression typeAccess(Element element) { 127 js.Expression typeAccess(Element element) {
128 // TODO(floitsch): minify 'ensureResolved'. 128 // TODO(floitsch): minify 'ensureResolved'.
129 // TODO(floitsch): don't emit `ensureResolved` for eager classes. 129 // TODO(floitsch): don't emit `ensureResolved` for eager classes.
130 return js.js('#.ensureResolved()', _globalPropertyAccess(element)); 130 return js.js('#.ensureResolved()', _globalPropertyAccess(element));
131 } 131 }
132 132
133 @override 133 @override
134 js.Template templateForBuiltin(JsBuiltin builtin) { 134 js.Template templateForBuiltin(JsBuiltin builtin) {
135 String typeNameProperty = ModelEmitter.typeNameProperty;
136
137 switch (builtin) { 135 switch (builtin) {
138 case JsBuiltin.dartObjectConstructor: 136 case JsBuiltin.dartObjectConstructor:
139 return js.js.expressionTemplateYielding( 137 return js.js.expressionTemplateYielding(
140 typeAccess(_compiler.objectClass)); 138 typeAccess(_compiler.objectClass));
141 139
142 case JsBuiltin.isCheckPropertyToJsConstructorName: 140 case JsBuiltin.isCheckPropertyToJsConstructorName:
143 int isPrefixLength = namer.operatorIsPrefix.length; 141 int isPrefixLength = namer.operatorIsPrefix.length;
144 return js.js.expressionTemplateFor('#.substring($isPrefixLength)'); 142 return js.js.expressionTemplateFor('#.substring($isPrefixLength)');
145 143
146 case JsBuiltin.isFunctionType: 144 case JsBuiltin.isFunctionType:
147 return _backend.rti.representationGenerator.templateForIsFunctionType; 145 return _backend.rti.representationGenerator.templateForIsFunctionType;
148 146
149 case JsBuiltin.rawRtiToJsConstructorName: 147 case JsBuiltin.rawRtiToJsConstructorName:
150 return js.js.expressionTemplateFor("#.$typeNameProperty"); 148 return js.js.expressionTemplateFor("#.name");
151 149
152 case JsBuiltin.rawRuntimeType: 150 case JsBuiltin.rawRuntimeType:
153 return js.js.expressionTemplateFor("#.constructor"); 151 return js.js.expressionTemplateFor("#.constructor");
154 152
155 case JsBuiltin.createFunctionTypeRti: 153 case JsBuiltin.createFunctionTypeRti:
156 return _backend.rti.representationGenerator 154 return _backend.rti.representationGenerator
157 .templateForCreateFunctionType; 155 .templateForCreateFunctionType;
158 156
159 case JsBuiltin.isSubtype: 157 case JsBuiltin.isSubtype:
160 // TODO(floitsch): move this closer to where is-check properties are 158 // TODO(floitsch): move this closer to where is-check properties are
161 // built. 159 // built.
162 String isPrefix = namer.operatorIsPrefix; 160 String isPrefix = namer.operatorIsPrefix;
163 return js.js.expressionTemplateFor("('$isPrefix' + #) in #.prototype"); 161 return js.js.expressionTemplateFor("('$isPrefix' + #) in #.prototype");
164 162
165 case JsBuiltin.isGivenTypeRti: 163 case JsBuiltin.isGivenTypeRti:
166 return js.js.expressionTemplateFor('#.$typeNameProperty === #'); 164 return js.js.expressionTemplateFor('#.name === #');
167 165
168 case JsBuiltin.getMetadata: 166 case JsBuiltin.getMetadata:
169 return _emitter.templateForReadMetadata; 167 return _emitter.templateForReadMetadata;
170 168
171 case JsBuiltin.getType: 169 case JsBuiltin.getType:
172 return _emitter.templateForReadType; 170 return _emitter.templateForReadType;
173 171
174 default: 172 default:
175 _compiler.internalError(NO_LOCATION_SPANNABLE, 173 _compiler.internalError(NO_LOCATION_SPANNABLE,
176 "Unhandled Builtin: $builtin"); 174 "Unhandled Builtin: $builtin");
177 return null; 175 return null;
178 } 176 }
179 } 177 }
180 178
181 @override 179 @override
182 void invalidateCaches() { 180 void invalidateCaches() {
183 } 181 }
184 } 182 }
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698