Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1212663004: dart2js cps: Fix a couple of minor issues. (Closed)

Created:
5 years, 5 months ago by asgerf
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 chunk +1 line, -3 lines 1 comment Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 chunk +1 line, -1 line 1 comment Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 5 (1 generated)
asgerf
https://codereview.chromium.org/1212663004/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart File pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart (right): https://codereview.chromium.org/1212663004/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart#newcode292 pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart:292: bool receiverIsNotNull = false; The tree builder expects this ...
5 years, 5 months ago (2015-06-29 14:09:12 UTC) #2
Kevin Millikin (Google)
lgtm https://codereview.chromium.org/1212663004/diff/1/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart File pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart (right): https://codereview.chromium.org/1212663004/diff/1/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart#newcode323 pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart:323: if (continuation.hasMultipleUses || continuation.isRecursive) { On 2015/06/29 14:09:12, ...
5 years, 5 months ago (2015-06-29 14:43:28 UTC) #3
Kevin Millikin (Google)
lgtm
5 years, 5 months ago (2015-06-29 14:43:29 UTC) #4
asgerf
5 years, 5 months ago (2015-06-29 14:45:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
009cc956d11c7ad9c099848f80157ce25e265abf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698