Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart

Issue 1212663004: dart2js cps: Fix a couple of minor issues. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
index 0d663c551beec084407fc5ed1574fca789ba1e25..6e39aae97a7524a880391cedc57a60d0841a2051 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
@@ -320,7 +320,7 @@ class Builder implements cps_ir.Visitor<Node> {
// Introduce labels for continuations that need them.
int safeForInliningLengthOnEntry = safeForInlining.length;
for (cps_ir.Continuation continuation in node.continuations) {
- if (continuation.hasMultipleUses) {
+ if (continuation.hasMultipleUses || continuation.isRecursive) {
asgerf 2015/06/29 14:09:12 If the continuation is marked as recursive, but al
Kevin Millikin (Google) 2015/06/29 14:43:28 The way we do it now has always seemed brittle; we
labels[continuation] = new Label();
} else {
safeForInlining.add(continuation);

Powered by Google App Engine
This is Rietveld 408576698