Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1212503004: Tighten up dependencies in the task model. (Closed)

Created:
5 years, 5 months ago by Paul Berry
Modified:
5 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tighten up dependencies in the task model. - ResolveLibraryTypeNamesTask doesn't need to depend on RESOLVED_UNIT3 for all sources in the transitive closure of imports; it only needs RESOLVED_UNIT3 for the units constituting the current library. - ResolveVariableReferencesTask doesn't need to depend on LIBRARY_ELEMENT6 for all libraries in the transitive closure of imports, because it only resolves references to locals and parameters, and they can only resolve to elements in the same compilation unit; the transitive closure is not needed until ResolveUnitReferencesTask. - ResolveVariableReferencesTask doesn't need LIBRARY_ELEMENT6 of the current library, since it only needs the LibraryElement to initialize the scope chain; LIBRARY_ELEMENT1 is sufficient. - ResolveVariableReferencesTask doesn't need RESOLVED_UNIT3 of the current library, since it only needs to ensure that the elements for locals and parameters have been built; RESOLVED_UNIT1 is sufficient. This should help reduce the amount of analysis which has to be performed before code completions can be produced. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/967d4b382063e41c1204976ca5b5e8152eed32ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -31 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 4 chunks +10 lines, -12 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 3 chunks +4 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 5 months ago (2015-06-26 22:02:09 UTC) #2
scheglov
LGTM
5 years, 5 months ago (2015-06-27 01:45:46 UTC) #3
Paul Berry
5 years, 5 months ago (2015-06-27 04:56:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
967d4b382063e41c1204976ca5b5e8152eed32ff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698