Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: pkg/analyzer/test/src/task/dart_test.dart

Issue 1212503004: Tighten up dependencies in the task model. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/task/dart_test.dart
diff --git a/pkg/analyzer/test/src/task/dart_test.dart b/pkg/analyzer/test/src/task/dart_test.dart
index e8b58134213a12e130e2a0b210daad715854d874..857f352d2326da25180d46f1da9955d790a5f34d 100644
--- a/pkg/analyzer/test/src/task/dart_test.dart
+++ b/pkg/analyzer/test/src/task/dart_test.dart
@@ -2338,7 +2338,7 @@ class C extends A {}
}
}
- test_perform_deep() {
+ test_perform_external() {
Source sourceA = newSource('/a.dart', '''
library a;
import 'b.dart';
@@ -2346,18 +2346,10 @@ class A extends B {}
''');
newSource('/b.dart', '''
library b;
-import 'c.dart';
-part 'b2.dart';
-class B extends B2 {}
-''');
- newSource('/b2.dart', '''
-part of b;
-class B2 extends C {}
-''');
- newSource('/c.dart', '''
-library c;
-class C {}
+class B {}
''');
+ // The reference A to B should be resolved, but there's no requirement that
+ // the full class hierarchy be resolved.
computeResult(sourceA, LIBRARY_ELEMENT5);
expect(task, new isInstanceOf<ResolveLibraryTypeNamesTask>());
// validate
@@ -2367,13 +2359,6 @@ class C {}
expect(clazz.displayName, 'A');
clazz = clazz.supertype.element;
expect(clazz.displayName, 'B');
- clazz = clazz.supertype.element;
- expect(clazz.displayName, 'B2');
- clazz = clazz.supertype.element;
- expect(clazz.displayName, 'C');
- clazz = clazz.supertype.element;
- expect(clazz.displayName, 'Object');
- expect(clazz.supertype, isNull);
}
}
}
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698