Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1211593004: Fix (optimizer) crashes in conditional nodes when result is not needed. (Closed)

Created:
5 years, 6 months ago by srdjan
Modified:
5 years, 6 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix (optimizer) crashes in conditional nodes when result is not needed. BUG= R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/fbc9f6b9d841dbfa76dcb08a5c45db10334827c6

Patch Set 1 #

Patch Set 2 : x #

Patch Set 3 : x #

Patch Set 4 : z #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -67 lines) Patch
M runtime/vm/flow_graph_builder.h View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 3 chunks +105 lines, -67 lines 0 comments Download
M tests/language/nullaware_opt_test.dart View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
srdjan
5 years, 6 months ago (2015-06-24 18:12:53 UTC) #2
hausner
LGTM. Thank you for fixing this.
5 years, 6 months ago (2015-06-24 18:24:11 UTC) #3
srdjan
5 years, 6 months ago (2015-06-24 18:32:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
fbc9f6b9d841dbfa76dcb08a5c45db10334827c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698