Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: runtime/vm/flow_graph_builder.h

Issue 1211593004: Fix (optimizer) crashes in conditional nodes when result is not needed. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: z Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_FLOW_GRAPH_BUILDER_H_ 5 #ifndef VM_FLOW_GRAPH_BUILDER_H_
6 #define VM_FLOW_GRAPH_BUILDER_H_ 6 #define VM_FLOW_GRAPH_BUILDER_H_
7 7
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "platform/globals.h" 9 #include "platform/globals.h"
10 #include "vm/allocation.h" 10 #include "vm/allocation.h"
(...skipping 459 matching lines...) Expand 10 before | Expand all | Expand 10 after
470 const intptr_t old_ctx_level, 470 const intptr_t old_ctx_level,
471 JoinEntryInstr* target); 471 JoinEntryInstr* target);
472 472
473 void BuildAsyncJump(LocalVariable* old_context, 473 void BuildAsyncJump(LocalVariable* old_context,
474 LocalVariable* continuation_result, 474 LocalVariable* continuation_result,
475 LocalVariable* continuation_error, 475 LocalVariable* continuation_error,
476 LocalVariable* continuation_stack_trace, 476 LocalVariable* continuation_stack_trace,
477 const intptr_t old_ctx_level, 477 const intptr_t old_ctx_level,
478 JoinEntryInstr* target); 478 JoinEntryInstr* target);
479 479
480 void BuildInstanceGetterConditional(InstanceGetterNode* node);
481 void BuildInstanceCallConditional(InstanceCallNode* node);
482
480 Isolate* isolate() const { return owner()->isolate(); } 483 Isolate* isolate() const { return owner()->isolate(); }
481 Zone* zone() const { return owner()->zone(); } 484 Zone* zone() const { return owner()->zone(); }
482 485
483 private: 486 private:
484 friend class TempLocalScope; // For ReturnDefinition. 487 friend class TempLocalScope; // For ReturnDefinition.
485 488
486 // Helper to drop the result value. 489 // Helper to drop the result value.
487 virtual void ReturnValue(Value* value) { 490 virtual void ReturnValue(Value* value) {
488 Do(new DropTempsInstr(0, value)); 491 Do(new DropTempsInstr(0, value));
489 } 492 }
(...skipping 28 matching lines...) Expand all
518 : EffectGraphVisitor(owner), value_(NULL) { } 521 : EffectGraphVisitor(owner), value_(NULL) { }
519 522
520 // Visit functions overridden by this class. 523 // Visit functions overridden by this class.
521 virtual void VisitAssignableNode(AssignableNode* node); 524 virtual void VisitAssignableNode(AssignableNode* node);
522 virtual void VisitConstructorCallNode(ConstructorCallNode* node); 525 virtual void VisitConstructorCallNode(ConstructorCallNode* node);
523 virtual void VisitBinaryOpNode(BinaryOpNode* node); 526 virtual void VisitBinaryOpNode(BinaryOpNode* node);
524 virtual void VisitConditionalExprNode(ConditionalExprNode* node); 527 virtual void VisitConditionalExprNode(ConditionalExprNode* node);
525 virtual void VisitLoadLocalNode(LoadLocalNode* node); 528 virtual void VisitLoadLocalNode(LoadLocalNode* node);
526 virtual void VisitStoreIndexedNode(StoreIndexedNode* node); 529 virtual void VisitStoreIndexedNode(StoreIndexedNode* node);
527 virtual void VisitInstanceSetterNode(InstanceSetterNode* node); 530 virtual void VisitInstanceSetterNode(InstanceSetterNode* node);
531 virtual void VisitInstanceGetterNode(InstanceGetterNode* node);
528 virtual void VisitThrowNode(ThrowNode* node); 532 virtual void VisitThrowNode(ThrowNode* node);
529 virtual void VisitClosureCallNode(ClosureCallNode* node); 533 virtual void VisitClosureCallNode(ClosureCallNode* node);
530 virtual void VisitStaticSetterNode(StaticSetterNode* node); 534 virtual void VisitStaticSetterNode(StaticSetterNode* node);
531 virtual void VisitStoreStaticFieldNode(StoreStaticFieldNode* node); 535 virtual void VisitStoreStaticFieldNode(StoreStaticFieldNode* node);
532 virtual void VisitTypeNode(TypeNode* node); 536 virtual void VisitTypeNode(TypeNode* node);
533 virtual void VisitLetNode(LetNode* node); 537 virtual void VisitLetNode(LetNode* node);
538 virtual void VisitInstanceCallNode(InstanceCallNode* node);
534 539
535 Value* value() const { return value_; } 540 Value* value() const { return value_; }
536 541
537 protected: 542 protected:
538 // Output parameters. 543 // Output parameters.
539 Value* value_; 544 Value* value_;
540 545
541 private: 546 private:
542 // Helper to set the output state to return a Value. 547 // Helper to set the output state to return a Value.
543 virtual void ReturnValue(Value* value) { value_ = value; } 548 virtual void ReturnValue(Value* value) { value_ = value; }
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
609 // Output parameters. 614 // Output parameters.
610 GrowableArray<TargetEntryInstr**> true_successor_addresses_; 615 GrowableArray<TargetEntryInstr**> true_successor_addresses_;
611 GrowableArray<TargetEntryInstr**> false_successor_addresses_; 616 GrowableArray<TargetEntryInstr**> false_successor_addresses_;
612 617
613 intptr_t condition_token_pos_; 618 intptr_t condition_token_pos_;
614 }; 619 };
615 620
616 } // namespace dart 621 } // namespace dart
617 622
618 #endif // VM_FLOW_GRAPH_BUILDER_H_ 623 #endif // VM_FLOW_GRAPH_BUILDER_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698