Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1210403008: dart2js cps: Bugfix in operator specialization. (Closed)

Created:
5 years, 5 months ago by asgerf
Modified:
5 years, 5 months ago
Reviewers:
karlklose, floitsch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Bugfix in operator specialization. Binary operators were always replaced with string concatenation if both operands were strings. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/02203937972fcff2c1de832ac02afae38e04b415

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 chunk +4 lines, -2 lines 1 comment Download
A tests/language/string_no_operator_test.dart View 1 chunk +26 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
asgerf
5 years, 5 months ago (2015-07-06 08:31:40 UTC) #2
floitsch
LGTM.
5 years, 5 months ago (2015-07-06 09:14:12 UTC) #3
asgerf
Committed patchset #1 (id:1) manually as 02203937972fcff2c1de832ac02afae38e04b415 (presubmit successful).
5 years, 5 months ago (2015-07-06 09:15:07 UTC) #4
karlklose
5 years, 5 months ago (2015-07-07 12:48:00 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1210403008/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right):

https://codereview.chromium.org/1210403008/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:685: if (node.selector.name ==
'+') {
You could also align this with the structure of the handling of 'operator =='.

https://codereview.chromium.org/1210403008/diff/1/tests/language/string_no_op...
File tests/language/string_no_operator_test.dart (right):

https://codereview.chromium.org/1210403008/diff/1/tests/language/string_no_op...
tests/language/string_no_operator_test.dart:8: var x = "x";
That's a lot of spaces.

Powered by Google App Engine
This is Rietveld 408576698