Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Unified Diff: pkg/compiler/lib/src/cps_ir/type_propagation.dart

Issue 1210403008: dart2js cps: Bugfix in operator specialization. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/type_propagation.dart
diff --git a/pkg/compiler/lib/src/cps_ir/type_propagation.dart b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
index 67159305c2afd2ff430ca50e70d425ddd132dddc..f60b28ab55bf056af70a5fd00ca0315e8c0a0983 100644
--- a/pkg/compiler/lib/src/cps_ir/type_propagation.dart
+++ b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
@@ -682,8 +682,10 @@ class TransformingVisitor extends RecursiveVisitor {
}
else if (lattice.isDefinitelyString(left, allowNull: false) &&
lattice.isDefinitelyString(right, allowNull: false)) {
- return replaceWithBinary(BuiltinOperator.StringConcatenate,
- leftArg, rightArg);
+ if (node.selector.name == '+') {
karlklose 2015/07/07 12:48:00 You could also align this with the structure of th
+ return replaceWithBinary(BuiltinOperator.StringConcatenate,
+ leftArg, rightArg);
+ }
}
}
}
« no previous file with comments | « no previous file | tests/language/string_no_operator_test.dart » ('j') | tests/language/string_no_operator_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698