dart2js: Extract minified field naming into mixin.

dart2js: Extract minified field naming into mixin.

R=johnniwinther@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/d24580087db722f4399fb788196f04cb055e062b

[Johnni Winther, 2015-06-26 10:03:35]

lgtm

https://codereview.chromium.org/1209973002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/field_naming_mixin.dart (right):

https://codereview.chromium.org/1209973002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/field_naming_mixin.dart:56: jsAst.Name
getName(int count) {
Document the significance of [count]. Maybe rename it to [index]?

https://codereview.chromium.org/1209973002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/minify_namer.dart (right):

https://codereview.chromium.org/1209973002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/minify_namer.dart:36: Set<String> usedNames,
Identation is off.

[herhut, 2015-06-29 12:19:31]

https://codereview.chromium.org/1209973002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/field_naming_mixin.dart (right):

https://codereview.chromium.org/1209973002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/field_naming_mixin.dart:56: jsAst.Name
getName(int count) {
On 2015/06/26 10:03:35, Johnni Winther wrote:
> Document the significance of [count]. Maybe rename it to [index]?

Done.

https://codereview.chromium.org/1209973002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/minify_namer.dart (right):

https://codereview.chromium.org/1209973002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/minify_namer.dart:36: Set<String> usedNames,
On 2015/06/26 10:03:35, Johnni Winther wrote:
> Identation is off.

Done.

[herhut, 2015-06-29 12:20:04]

Committed patchset #2 (id:20001) manually as
d24580087db722f4399fb788196f04cb055e062b (presubmit successful).