Issue 12089049: Do not add smis to the store buffer when cloning objects.

Issue 12089049: Do not add smis to the store buffer when cloning objects. (Closed)

Created:
7 years, 10 months ago by Florian Schneider

Modified:
7 years, 10 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Do not add smis to the store buffer when cloning objects. StoreBufferObjectPointerVisitor did not check for smis. It is used from Object::Clone. Also assert that IsNewObject and IsOldObject is only called on heap objects. Committed: https://code.google.com/p/dart/source/detail?r=17804

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	runtime/vm/object.cc	View	1	3 chunks	+8 lines, -7 lines	0 comments	Download
	M	runtime/vm/raw_object.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Good catch! LGTM -Ivan https://codereview.chromium.org/12089049/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/12089049/diff/1/runtime/vm/object.cc#newcode1303 runtime/vm/object.cc:1303: class StoreBufferObjectPointerVisitor : public ObjectPointerVisitor ...

7 years, 10 months ago (2013-01-29 17:55:09 UTC) #3

Florian Schneider

7 years, 10 months ago (2013-01-29 20:04:19 UTC) #4

https://codereview.chromium.org/12089049/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/12089049/diff/1/runtime/vm/object.cc#newcode1303
runtime/vm/object.cc:1303: class StoreBufferObjectPointerVisitor : public
ObjectPointerVisitor {
On 2013/01/29 17:55:09, Ivan Posva wrote:
> How about renaming this to StoreBufferUpdateVisitor?

Done.

https://codereview.chromium.org/12089049/diff/1/runtime/vm/object.cc#newcode1310
runtime/vm/object.cc:1310: if ((*curr)->IsHeapObject() &&
(*curr)->IsNewObject()) {
On 2013/01/29 17:55:09, Ivan Posva wrote:
> RawObject* raw_obj = *curr;
> if (raw_obj->IsHeapObject() && raw_obj->IsNewObject()) {

Done.

Expand Messages | Collapse Messages