Issue 12087094: Removed Dynamic keyword support from dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12087094: Removed Dynamic keyword support from dart2js. (Closed)

Created:
7 years, 10 months ago by aam-me

Modified:
7 years, 9 months ago

Reviewers:
ahe, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Removed Dynamic keyword support from dart2js. BUG=dartbug.com/7815 Committed: https://code.google.com/p/dart/source/detail?r=19353

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -39 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/scanner/keyword.dart	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/scanner/parser.dart	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/scanner/scanner.dart	View		2 chunks	+0 lines, -30 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

aam-me

Hi, Peter, I thought it might be good time to remove Dynamic keyword support from ...

7 years, 10 months ago (2013-01-31 01:38:35 UTC) #1

ngeoffray

LGTM! (Giving you a chance to submit before I get an LGTM :-))

7 years, 9 months ago (2013-03-01 21:00:23 UTC) #2

aam-me

Committed patchset #2 manually as r19353 (presubmit successful).

7 years, 9 months ago (2013-03-02 03:26:21 UTC) #3

aam-me

7 years, 9 months ago (2013-03-02 03:58:33 UTC) #4

Message was sent while issue was closed.

On 2013/03/01 21:00:23, ngeoffray wrote:
> LGTM! (Giving you a chance to submit before I get an LGTM :-))

Thank you, Nicolas!