sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart - Issue 12087094: Removed Dynamic keyword support from dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

Issue 12087094: Removed Dynamic keyword support from dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Copied inherited dart2js test status to dart2dart status file. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

index 669aa02407bde8bfa5afbb9db2ace8e3a5d84cc3..693afa03db84e87e7e46fd138148c5c1659050d9 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

@@ -448,8 +448,7 @@ class PlaceholderCollector extends Visitor {

static bool isDynamicType(TypeAnnotation typeAnnotation) {

if (!isPlainTypeName(typeAnnotation)) return false;

String name = typeAnnotation.typeName.asIdentifier().source.slowToString();

- // TODO(aprelev@gmail.com): Removed deprecated Dynamic keyword support.

- return name == 'Dynamic' || name == 'dynamic';

+ return name == 'dynamic';

}

visitTypeAnnotation(TypeAnnotation node) {

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/scanner/keyword.dart » ('j') | no next file with comments »