Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 12087004: Changing window.requestLayoutFrame into a microtask API (Closed)

Created:
7 years, 11 months ago by blois
Modified:
7 years, 11 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

A couple of changes to change Window.requestLayoutFrame into a microtask API. - Renamed window.requestLayoutFrame to window.setImmediate. - Added support for IE's window.setImmediate - Converted Element.getComputedStyle to be synchronous - Removed Element.computedStyle, should use Element.getComputedStyle. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17681

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+415 lines, -545 lines) Patch
M samples/swarm/Views.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/layout/GridLayout.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/layout/ViewLayout.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M samples/swarm/swarm_ui_lib/touch/Scroller.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M samples/swarm/swarm_ui_lib/view/PagedViews.dart View 6 chunks +7 lines, -6 lines 0 comments Download
M samples/swarm/swarm_ui_lib/view/SliderMenu.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/view/view.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 8 chunks +80 lines, -121 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 8 chunks +79 lines, -121 lines 0 comments Download
M tests/html/cssstyledeclaration_test.dart View 2 chunks +6 lines, -12 lines 0 comments Download
D tests/html/measurement_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
A tests/html/microtask_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download
D tools/dom/src/Measurement.dart View 1 chunk +0 lines, -200 lines 0 comments Download
A tools/dom/src/Microtask.dart View 1 1 chunk +156 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/impl_Window.darttemplate View 2 chunks +15 lines, -5 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/impl_Window.darttemplate View 2 chunks +14 lines, -5 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +9 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
7 years, 11 months ago (2013-01-25 23:09:50 UTC) #1
Jacob
https://codereview.chromium.org/12087004/diff/1/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (left): https://codereview.chromium.org/12087004/diff/1/sdk/lib/html/dartium/html_dartium.dart#oldcode34128 sdk/lib/html/dartium/html_dartium.dart:34128: const _MEASUREMENT_MESSAGE = "DART-MEASURE"; change this constant to have ...
7 years, 11 months ago (2013-01-25 23:19:59 UTC) #2
blois
https://codereview.chromium.org/12087004/diff/1/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (left): https://codereview.chromium.org/12087004/diff/1/sdk/lib/html/dartium/html_dartium.dart#oldcode34128 sdk/lib/html/dartium/html_dartium.dart:34128: const _MEASUREMENT_MESSAGE = "DART-MEASURE"; On 2013/01/25 23:19:59, Jacob wrote: ...
7 years, 11 months ago (2013-01-25 23:25:56 UTC) #3
Jacob
7 years, 11 months ago (2013-01-25 23:27:46 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698