samples/swarm/swarm_ui_lib/view/SliderMenu.dart - Issue 12087004: Changing window.requestLayoutFrame into a microtask API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/swarm/swarm_ui_lib/view/SliderMenu.dart

Issue 12087004: Changing window.requestLayoutFrame into a microtask API (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: samples/swarm/swarm_ui_lib/view/SliderMenu.dart

diff --git a/samples/swarm/swarm_ui_lib/view/SliderMenu.dart b/samples/swarm/swarm_ui_lib/view/SliderMenu.dart

index 20a58a76ef122067bd3d631938e4705f0f2184a7..2561ce667cf0e9a43e538e5b5cfa7abb1a50ad3e 100644

--- a/samples/swarm/swarm_ui_lib/view/SliderMenu.dart

+++ b/samples/swarm/swarm_ui_lib/view/SliderMenu.dart

@@ -157,7 +157,7 @@ class SliderMenu extends View {

void updateIndicator(bool animate) {

if (selectedItem != null) {

// calculate where we want to put the triangle

- window.requestLayoutFrame(() {

+ window.setImmediate(() {

num x = selectedItem.offsetLeft +

selectedItem.offsetWidth / 2 - TRIANGLE_WIDTH / 2;

_moveIndicator(x, animate);

« no previous file with comments | « samples/swarm/swarm_ui_lib/view/PagedViews.dart ('k') | samples/swarm/swarm_ui_lib/view/view.dart » ('j') | no next file with comments »