Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 12086080: Fix debugger test. (Closed)

Created:
7 years, 10 months ago by Mads Ager (google)
Modified:
7 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix debugger test. 1. Fix JSON import. 2. Add exit code check to catch such errors in the future. 3. Only kill the debugee on errors. If there are no errors it will die on its own with exit code 0. If we kill it explicitly it can get killed (and give exit code != 0) before it has the chance to exit on its own. R=sgjesse@google.com,tball@google.com,hausner@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17889

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M tests/standalone/debugger/debug_lib.dart View 4 chunks +13 lines, -10 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
7 years, 10 months ago (2013-01-31 09:08:00 UTC) #1
Søren Gjesse
lgtm
7 years, 10 months ago (2013-01-31 09:08:50 UTC) #2
Tom Ball
7 years, 10 months ago (2013-01-31 14:59:26 UTC) #3
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/12086080/diff/1/tests/standalone/debugger/deb...
File tests/standalone/debugger/debug_lib.dart (right):

https://codereview.chromium.org/12086080/diff/1/tests/standalone/debugger/deb...
tests/standalone/debugger/debug_lib.dart:433: close(killDebugee: true);
Spelling: should be "debuggee", to match "debugger".  Of course there's no such
word as "debuggee", but when has that stopped a software engineer? :-)

Powered by Google App Engine
This is Rietveld 408576698