Fix debugger test.

tests/standalone/debugger/debug_lib.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Library used by debugger wire protocol tests (standalone VM debugging).
 
 library DartDebugger;
 
 import "dart:io";
 import "dart:utf";
-import "dart:json";
+import "dart:json" as JSON;
 
 // TODO(hausner): need to select a different port number for each
 // test that runs in parallel.
 var debugPort = 5860;
 
 // Whether or not to print debug target process on the console.
 var showDebuggeeOutput = true;
 
 // Whether or not to print the debugger wire messages on the console.
 var verboseWire = false;
@@ skipping 401 matching lines @@
   // message objects (maps).
   void handleMessages() {
     var msg = responses.getNextMessage();
     while (msg != null) {
       if (verboseWire) print("RECV: $msg");
       var msgObj = JSON.parse(msg);
       handleMessage(msgObj);
       if (errorsDetected) {
         error("Error while handling script entry ${script.currentIndex}");
         error("Message received from debug target: $msg");
-        close();
+        close(killDebugee: true);

[Tom Ball, 2013/01/31 14:59:26]

Spelling: should be "debuggee", to match "debugger".  Of course there's no such
word as "debuggee", but when has that stopped a software engineer? :-)

         return;
       }
       if (shutdownEventSeen) {
         close();
         return;
       }
       sendNextCommand();
       msg = responses.getNextMessage();
     }
   }
@@ skipping 20 matching lines @@
   void openConnection() {
     socket = new Socket("127.0.0.1", portNumber);
     to = socket.outputStream;
     from = new StringInputStream(socket.inputStream, Encoding.UTF_8);
     from.onData = () {
       try {
         responses.append(from.read());
         handleMessages();
       } catch(e, trace) {
         print("Unexpected exception:\n$e\n$trace");
-        close();
+        close(killDebugee: true);
       }
     };
     from.onClosed = () {
       print("Connection closed by debug target");
-      close();
+      close(killDebugee: true);
     };
     from.onError = (e) {
       print("Error '$e' detected in input stream from debug target");
-      close();
+      close(killDebugee: true);
     };
   }
 
-  void close() {
+  void close({killDebugee: false}) {
     if (errorsDetected) {
       for (int i = 0; i < errors.length; i++) print(errors[i]);
     }
     to.close();
     socket.close();
-    targetProcess.kill();
-    print("Target process killed");
+    if (killDebugee) {
+      targetProcess.kill();
+      print("Target process killed");
+    }
     Expect.isTrue(!errorsDetected);
     stdin.close();
     stdout.close();
     stderr.close();
   }
 }
 
 
 bool RunScript(List script) {
   var options = new Options();
   if (options.arguments.contains("--debuggee")) {
     return false;
   }
   showDebuggeeOutput = options.arguments.contains("--verbose");
   verboseWire = options.arguments.contains("--wire");
 
   var targetOpts = [ "--debug:$debugPort" ];
   if (showDebuggeeOutput) targetOpts.add("--verbose_debug");
   targetOpts.add(options.script);
   targetOpts.add("--debuggee");
 
   Process.start(options.executable, targetOpts).then((Process process) {
     print("Debug target process started");
     process.stdin.close();
     process.stdout.onData = process.stdout.read;
     process.stderr.onData = process.stderr.read;
     process.onExit = (int exitCode) {
+      Expect.equals(0, exitCode);
       print("Debug target process exited with exit code $exitCode");
     };
     var debugger = new Debugger(process, debugPort);
-    stdin.onClosed = () => debugger.close();
-    stdin.onError = (error) => debugger.close();
+    stdin.onClosed = () => debugger.close(killDebugee: true);
+    stdin.onError = (error) => debugger.close(killDebugee: true);
     debugger.runScript(script);
   });
   return true;
 }