Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 12082024: Use named arguments for messages. (Closed)

Created:
7 years, 10 months ago by Johnni Winther
Modified:
7 years, 10 months ago
Reviewers:
ahe, ngeoffray, kasperl
CC:
reviews_dartlang.org, ngeoffray, karlklose
Visibility:
Public.

Description

Use named arguments for messages. Committed: https://code.google.com/p/dart/source/detail?r=17745

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -273 lines) Patch
M sdk/lib/_internal/compiler/implementation/compile_time_constants.dart View 8 chunks +10 lines, -10 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/compiler.dart View 3 chunks +7 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/library_loader.dart View 3 chunks +10 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 69 chunks +160 lines, -129 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 6 chunks +8 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/types.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/util/util.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 1 17 chunks +115 lines, -101 lines 0 comments Download
M tests/compiler/dart2js/erroneous_element_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/part_of_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 5 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
7 years, 10 months ago (2013-01-28 11:57:07 UTC) #1
ngeoffray
LGTM
7 years, 10 months ago (2013-01-28 12:02:49 UTC) #2
ahe
7 years, 10 months ago (2013-01-29 18:35:20 UTC) #3
Message was sent while issue was closed.
Thank you!

Powered by Google App Engine
This is Rietveld 408576698