Use named arguments for messages.

tests/compiler/dart2js/resolver_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:collection';
 import 'dart:uri';
 
 import "../../../sdk/lib/_internal/compiler/implementation/resolution/resolution.dart";
 import "../../../sdk/lib/_internal/compiler/implementation/elements/elements.dart";
 import "../../../sdk/lib/_internal/compiler/implementation/tree/tree.dart";
@@ skipping 201 matching lines @@
   testLocals([["foo", false], ["bar", true]]);
   testLocals([["foo", true], ["bar", true]]);
 
   testLocals([["foo", false], ["bar", false], ["foobar", true]]);
   testLocals([["foo", false], ["bar", true], ["foobar", true]]);
   testLocals([["foo", true], ["bar", true], ["foobar", true]]);
 
   MockCompiler compiler = testLocals([["foo", false], ["foo", false]]);
   Expect.equals(1, compiler.errors.length);
   Expect.equals(
-      new Message(MessageKind.DUPLICATE_DEFINITION, ['foo']),
+      new Message(MessageKind.DUPLICATE_DEFINITION, {'name': 'foo'}),
       compiler.errors[0].message);
 }
 
 
 testLocalsTwo() {
   MockCompiler compiler = new MockCompiler();
   ResolverVisitor visitor = compiler.resolverVisitor();
   Node tree = parseStatement("if (true) { var a = 1; var b = 2; }");
   Element element = visitor.visit(tree);
   Expect.equals(null, element);
@@ skipping 161 matching lines @@
 
   // Test that we get a warning when Foo is not defined.
   Map mapping = compiler.resolveStatement(statement).map;
 
   Expect.equals(2, mapping.length); // Both Foo and bar have an element.
   Expect.equals(1, compiler.warnings.length);
 
   Node warningNode = compiler.warnings[0].node;
 
   Expect.equals(
-      new Message(MessageKind.CANNOT_RESOLVE_TYPE, ['Foo']),
+      new Message(MessageKind.CANNOT_RESOLVE_TYPE,  {'typeName': 'Foo'}),
       compiler.warnings[0].message);
   VariableDefinitions definition = compiler.parsedTree;
   Expect.equals(warningNode, definition.type);
   compiler.clearWarnings();
 
   // Test that there is no warning after defining Foo.
   compiler.parseScript("class Foo {}");
   mapping = compiler.resolveStatement(statement).map;
   Expect.equals(2, mapping.length);
   Expect.equals(0, compiler.warnings.length);
 
   // Test that 'var' does not create a warning.
   mapping = compiler.resolveStatement("var foo;").map;
   Expect.equals(1, mapping.length);
   Expect.equals(0, compiler.warnings.length);
 }
 
 testSuperclass() {
   MockCompiler compiler = new MockCompiler();
   compiler.parseScript("class Foo extends Bar {}");
   compiler.resolveStatement("Foo bar;");
   // TODO(ahe): We get the same error twice: once from
   // ClassResolverVisitor, and once from ClassSupertypeResolver. We
   // should only the get the error once.
   Expect.equals(2, compiler.errors.length);
-  var cannotResolveBar = new Message(MessageKind.CANNOT_RESOLVE_TYPE, ['Bar']);
+  var cannotResolveBar = new Message(MessageKind.CANNOT_RESOLVE_TYPE,
+                                     {'typeName': 'Bar'});
   Expect.equals(cannotResolveBar, compiler.errors[0].message);
   Expect.equals(cannotResolveBar, compiler.errors[1].message);
   compiler.clearErrors();
 
   compiler = new MockCompiler();
   compiler.parseScript("class Foo extends Bar {}");
   compiler.parseScript("class Bar {}");
   Map mapping = compiler.resolveStatement("Foo bar;").map;
   Expect.equals(2, mapping.length);
 
   ClassElement fooElement = compiler.mainApp.find(buildSourceString('Foo'));
   ClassElement barElement = compiler.mainApp.find(buildSourceString('Bar'));
   Expect.equals(barElement.computeType(compiler),
                 fooElement.supertype);
   Expect.isTrue(fooElement.interfaces.isEmpty);
   Expect.isTrue(barElement.interfaces.isEmpty);
 }
 
 testVarSuperclass() {
   MockCompiler compiler = new MockCompiler();
   compiler.parseScript("class Foo extends var {}");
   compiler.resolveStatement("Foo bar;");
   Expect.equals(1, compiler.errors.length);
   Expect.equals(
-      new Message(MessageKind.CANNOT_RESOLVE_TYPE, ['var']),
+      new Message(MessageKind.CANNOT_RESOLVE_TYPE, {'typeName': 'var'}),
       compiler.errors[0].message);
   compiler.clearErrors();
 }
 
 testOneInterface() {
   MockCompiler compiler = new MockCompiler();
   compiler.parseScript("class Foo implements Bar {}");
   compiler.resolveStatement("Foo bar;");
   Expect.equals(1, compiler.errors.length);
   Expect.equals(
-      new Message(MessageKind.CANNOT_RESOLVE_TYPE, ['bar']),
+      new Message(MessageKind.CANNOT_RESOLVE_TYPE, {'typeName': 'bar'}),
       compiler.errors[0].message);
   compiler.clearErrors();
 
   // Add the interface to the world and make sure everything is setup correctly.
   compiler.parseScript("interface Bar {}");
 
   ResolverVisitor visitor =
       new ResolverVisitor(compiler, null, new CollectingTreeElements(null));
   compiler.resolveStatement("Foo bar;");
 
@@ skipping 363 matching lines @@
         var d = new D();
         --d;
       }""";
   final compiler = compileScript(script);
 
   checkMemberResolved(compiler, 'A', operatorName('+', false));
   checkMemberResolved(compiler, 'B', operatorName('+', false));
   checkMemberResolved(compiler, 'C', operatorName('-', false));
   checkMemberResolved(compiler, 'D', operatorName('-', false));
 }