Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1208153002: Include pattern and functions for RegExps over the service protocol. Remove quadratic behavior from… (Closed)

Created:
5 years, 6 months ago by rmacnak
Modified:
5 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include pattern and functions for RegExps over the service protocol. Remove some quadratic behavior from processing/display of Code in Observatory, so we can actually look at 300k regexp instructions. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/69938db31a082d93b941e3526cdd0a29625842e5

Patch Set 1 #

Patch Set 2 : d observe #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -60 lines) Patch
M runtime/observatory/lib/src/elements/code_view.dart View 1 2 3 2 chunks +8 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref.html View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 3 chunks +61 lines, -27 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 10 chunks +40 lines, -27 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +20 lines, -1 line 0 comments Download
M runtime/vm/service/service.md View 1 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 6 months ago (2015-06-25 18:13:58 UTC) #2
Cutch
LGTM after fixing code comment issue https://codereview.chromium.org/1208153002/diff/40001/runtime/observatory/lib/src/elements/code_view.dart File runtime/observatory/lib/src/elements/code_view.dart (right): https://codereview.chromium.org/1208153002/diff/40001/runtime/observatory/lib/src/elements/code_view.dart#newcode201 runtime/observatory/lib/src/elements/code_view.dart:201: var n = ...
5 years, 6 months ago (2015-06-25 19:38:23 UTC) #3
rmacnak
https://codereview.chromium.org/1208153002/diff/40001/runtime/observatory/lib/src/elements/code_view.dart File runtime/observatory/lib/src/elements/code_view.dart (right): https://codereview.chromium.org/1208153002/diff/40001/runtime/observatory/lib/src/elements/code_view.dart#newcode201 runtime/observatory/lib/src/elements/code_view.dart:201: var n = row.values.length; On 2015/06/25 19:38:23, Cutch wrote: ...
5 years, 6 months ago (2015-06-25 19:50:26 UTC) #4
rmacnak
5 years, 6 months ago (2015-06-25 19:57:05 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
69938db31a082d93b941e3526cdd0a29625842e5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698