Issue 12079074: When comparing symbols during the range analysis check that both of them are not affected by side-e…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12079074: When comparing symbols during the range analysis check that both of them are not affected by side-e… (Closed)

Created:
7 years, 10 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 10 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

When comparing symbols during the range analysis check that both of them are not affected by side-effect. R=fschneider@google.com BUG=dart:8197 Committed: https://code.google.com/p/dart/source/detail?r=17840

Patch Set 1 #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	runtime/vm/intermediate_language.cc	View		1 chunk	+3 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

lgtm https://codereview.chromium.org/12079074/diff/1/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://codereview.chromium.org/12079074/diff/1/runtime/vm/intermediate_language.cc#newcode2127 runtime/vm/intermediate_language.cc:2127: return (a == b) || (!a->AffectedBySideEffect() && I'd ...

7 years, 10 months ago (2013-01-30 13:02:36 UTC) #2

Vyacheslav Egorov (Google)

7 years, 10 months ago (2013-01-30 13:04:55 UTC) #3

https://codereview.chromium.org/12079074/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/12079074/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.cc:2127: return (a == b) ||
(!a->AffectedBySideEffect() &&
On 2013/01/30 13:02:37, Florian Schneider wrote:
> I'd reformat this:
> 
> return (a == b)
>     || (!a->AffectedBySideEffect() &&
>         !b->AffectedBySideEffect() &&
>         a->Equals(b));

I don't like when one lines ends with && and starts with dangling ||.

Expand Messages | Collapse Messages