When comparing symbols during the range analysis check that both of them are not affected by side-e…

runtime/vm/intermediate_language.cc

Index: runtime/vm/intermediate_language.cc
diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc
index d4b82ea0c90d71b83f220c9bd4237e93c9f23212..6eb0613ccfb46e6ee17813a20f77b66a864b84fa 100644
--- a/runtime/vm/intermediate_language.cc
+++ b/runtime/vm/intermediate_language.cc
@@ -2124,7 +2124,9 @@ static Definition* UnwrapConstraint(Definition* defn) {
 static bool AreEqualDefinitions(Definition* a, Definition* b) {
   a = UnwrapConstraint(a);
   b = UnwrapConstraint(b);
-  return (a == b) || (!a->AffectedBySideEffect() && a->Equals(b));
+  return (a == b) || (!a->AffectedBySideEffect() &&

[Florian Schneider, 2013/01/30 13:02:37]

I'd reformat this:

return (a == b)
    || (!a->AffectedBySideEffect() &&
        !b->AffectedBySideEffect() &&
        a->Equals(b));

[Vyacheslav Egorov (Google), 2013/01/30 13:04:56]

I don't like when one lines ends with && and starts with dangling ||.

+      !b->AffectedBySideEffect() &&
+      a->Equals(b));
 }