Adding supported checks for WebGL

Adding supported checks for WebGL

Also fixed the getContext method to have the proper signature (bug 4883).

Also adding an easy accessor for context3d.

Not sure if additional Dartium changes will be needed, Anton?

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=17860

[sra1, 2013-01-29 02:17:34]

lgtm for the JS side.

https://codereview.chromium.org/12077039/diff/1/tools/dom/idl/dart/dart.idl
File tools/dom/idl/dart/dart.idl (right):

https://codereview.chromium.org/12077039/diff/1/tools/dom/idl/dart/dart.idl#n...
tools/dom/idl/dart/dart.idl:49: [Custom] CanvasRenderingContext
getContext([Optional=DefaultIsUndefined] in DOMString contextId, [Optional] in
Dictionary attrs);
Drop the [Optional=DefaultIsUndefined]
The generator ignores that since in JS it forces passing missing arguments -
something required to not break existing code that is missing mandatory
arguments.

[Anton Muhin, 2013-01-29 12:05:59]

Dartium ignores dictionary passed as of now, but that should be fix.  Please,
after you have submitted this, either file a new bug or reassign the existing
one to me.

https://codereview.chromium.org/12077039/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/12077039/diff/1/tests/html/html.status#newcode26
tests/html/html.status:26: webgl_1_test: Fail # Does not work on DRT
do you know why?

https://codereview.chromium.org/12077039/diff/1/tests/html/webgl_1_test.dart
File tests/html/webgl_1_test.dart (right):

https://codereview.chromium.org/12077039/diff/1/tests/html/webgl_1_test.dart#...
tests/html/webgl_1_test.dart:27: expect(gl is WebGLRenderingContext, true);
new IsInstanceOf<...>?  overall, it looks like you prefer values in places where
I'd rather use isTrue, isNull, etc.

https://codereview.chromium.org/12077039/diff/1/tests/html/webgl_1_test.dart#...
tests/html/webgl_1_test.dart:36: var gl =
canvas.getContext("experimental-webgl");
nit: mix of ' and "

[blois, 2013-01-29 21:50:08]

https://codereview.chromium.org/12077039/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/12077039/diff/1/tests/html/html.status#newcode26
tests/html/html.status:26: webgl_1_test: Fail # Does not work on DRT
On 2013/01/29 12:05:59, Anton Muhin wrote:
> do you know why?
WebGL is appearing as supported but the context creation fails. I assume this is
because it's running headless.

In general this test will fail on machines where the video driver does not
support WebGL- not sure of a good way to have a useful test but not fail in
these situations.

https://codereview.chromium.org/12077039/diff/1/tests/html/webgl_1_test.dart
File tests/html/webgl_1_test.dart (right):

https://codereview.chromium.org/12077039/diff/1/tests/html/webgl_1_test.dart#...
tests/html/webgl_1_test.dart:27: expect(gl is WebGLRenderingContext, true);
On 2013/01/29 12:05:59, Anton Muhin wrote:
> new IsInstanceOf<...>?  overall, it looks like you prefer values in places
where
> I'd rather use isTrue, isNull, etc.

Interesting- I only see one other test which uses isInstanceOf. Most of the core
tests use: Expect.isTrue(foo is Foo);

https://codereview.chromium.org/12077039/diff/1/tests/html/webgl_1_test.dart#...
tests/html/webgl_1_test.dart:36: var gl =
canvas.getContext("experimental-webgl");
On 2013/01/29 12:05:59, Anton Muhin wrote:
> nit: mix of ' and "

Done.

https://codereview.chromium.org/12077039/diff/1/tools/dom/idl/dart/dart.idl
File tools/dom/idl/dart/dart.idl (right):

https://codereview.chromium.org/12077039/diff/1/tools/dom/idl/dart/dart.idl#n...
tools/dom/idl/dart/dart.idl:49: [Custom] CanvasRenderingContext
getContext([Optional=DefaultIsUndefined] in DOMString contextId, [Optional] in
Dictionary attrs);
On 2013/01/29 02:17:34, sra1 wrote:
> Drop the [Optional=DefaultIsUndefined]
> The generator ignores that since in JS it forces passing missing arguments -
> something required to not break existing code that is missing mandatory
> arguments.

Done.

[Anton Muhin, 2013-01-30 12:23:02]

lgtm