Disallow access to static members of mixed in classes.

Disallow access to static members of mixed in classes.


R=johnniwinther@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=17384

[Johnni Winther, 2013-01-22 09:51:06]

lgtm

https://codereview.chromium.org/12051009/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/12051009/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1811: return
mixedInElement.isInstanceMember() ? mixedInElement : null;
In time, it might be better for the user feedback if we look up the static
member but disallow the access, instead of just not finding the member as with
this implementation.

[kasperl, 2013-01-22 10:30:02]

https://codereview.chromium.org/12051009/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/12051009/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1811: return
mixedInElement.isInstanceMember() ? mixedInElement : null;
On 2013/01/22 09:51:06, Johnni Winther wrote:
> In time, it might be better for the user feedback if we look up the static
> member but disallow the access, instead of just not finding the member as with
> this implementation.

True, so we would probably need a way of looking things up on a mixin
application that allows us to find extra stuff for better warnings.

[ahe, 2013-07-18 12:59:49]

DBC

https://codereview.chromium.org/12051009/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/12051009/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1815: if (mixin
!= null) mixin.forEachLocalMember((Element mixedInElement) {
Weird indentation.