Disallow access to static members of mixed in classes.

sdk/lib/_internal/compiler/implementation/elements/modelx.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library elements.modelx;
 
 import 'dart:uri';
 
 import 'elements.dart';
 import '../../compiler.dart' as api;
@@ skipping 1787 matching lines @@
   bool get isMixinApplication => true;
   bool get hasConstructor => constructor != null;
   bool get hasLocalScopeMembers => false;
 
   Token position() => node.getBeginToken();
 
   Node parseNode(DiagnosticListener listener) => node;
 
   Element localLookup(SourceString name) {
     if (this.name == name) return constructor;
-    if (mixin != null) return mixin.localLookup(name);
+    if (mixin == null) return null;
+    Element mixedInElement = mixin.localLookup(name);
+    if (mixedInElement == null) return null;
+    return mixedInElement.isInstanceMember() ? mixedInElement : null;

[Johnni Winther, 2013/01/22 09:51:06]

In time, it might be better for the user feedback if we look up the static
member but disallow the access, instead of just not finding the member as with
this implementation.

[kasperl, 2013/01/22 10:30:03]

True, so we would probably need a way of looking things up on a mixin
application that allows us to find extra stuff for better warnings.

   }
 
   void forEachLocalMember(void f(Element member)) {
-    if (mixin != null) mixin.forEachLocalMember(f);
+    if (mixin != null) mixin.forEachLocalMember((Element mixedInElement) {

[ahe, 2013/07/18 12:59:49]

Weird indentation.

+      if (mixedInElement.isInstanceMember()) f(mixedInElement);
+    });
   }
 
   void addMember(Element element, DiagnosticListener listener) {
     throw new UnsupportedError("cannot add member to $this");
   }
 
   void addToScope(Element element, DiagnosticListener listener) {
     throw new UnsupportedError("cannot add to scope of $this");
   }
 
@@ skipping 136 matching lines @@
 
   MetadataAnnotation ensureResolved(Compiler compiler) {
     if (resolutionState == STATE_NOT_STARTED) {
       compiler.resolver.resolveMetadataAnnotation(this);
     }
     return this;
   }
 
   String toString() => 'MetadataAnnotation($value, $resolutionState)';
 }