Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Issue 1204733002: dart2js cps: Make Identical a built-in and add Interceptor to Tree IR. (Closed)

Created:
5 years, 6 months ago by asgerf
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Make Identical a built-in and add Interceptor to Tree IR. Identical is now a built-in operator instead of a separate primitive. Interceptor is now its own expression in the Tree IR instead of a static invocation. This matches the CPS IR (where it is a primitive), and should fix a problem it was causing for frequency-based naming. The JS-specific subclass of the Tree IR builder no longer depended on the backend, emitter, namer, glue, compiler, or anything so it has been merged into the superclass. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/05497633df4c27dcbd99a9e942e9153d196f9673

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -208 lines) Patch
M pkg/compiler/lib/src/cps_ir/builtin_operator.dart View 3 chunks +10 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 4 chunks +9 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 3 chunks +0 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 2 chunks +0 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 6 chunks +53 lines, -43 lines 1 comment Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 2 chunks +13 lines, -0 lines 0 comments Download
D pkg/compiler/lib/src/js_backend/codegen/js_tree_builder.dart View 1 chunk +0 lines, -101 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/unsugar.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 2 chunks +48 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 5 chunks +26 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
https://codereview.chromium.org/1204733002/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart File pkg/compiler/lib/src/cps_ir/type_propagation.dart (left): https://codereview.chromium.org/1204733002/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart#oldcode572 pkg/compiler/lib/src/cps_ir/type_propagation.dart:572: if (use is Identical && use.hasNoUses) continue; Now that ...
5 years, 6 months ago (2015-06-23 13:25:40 UTC) #2
Kevin Millikin (Google)
LGTM.
5 years, 6 months ago (2015-06-23 13:43:04 UTC) #3
asgerf
5 years, 6 months ago (2015-06-23 14:04:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
05497633df4c27dcbd99a9e942e9153d196f9673 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698