pkg/compiler/lib/src/js_backend/codegen/unsugar.dart - Issue 1204733002: dart2js cps: Make Identical a built-in and add Interceptor to Tree IR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/unsugar.dart

Issue 1204733002: dart2js cps: Make Identical a built-in and add Interceptor to Tree IR. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/cps_ir/type_propagation.dart ('K') | « pkg/compiler/lib/src/js_backend/codegen/task.dart ('k') | pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_backend/codegen/unsugar.dart

diff --git a/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart b/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart

index 494828e8cd9909f5cf028e6b0dcf70559fb74ff0..bbe998f1f396f742fb02e2570ed10aa6e2a32156 100644

--- a/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart

+++ b/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart

@@ -125,7 +125,9 @@ class UnsugarVisitor extends RecursiveVisitor {

function.returnContinuation, <Primitive>[falsePrimitive]));

Primitive nullPrimitive = nullConstant;

- Primitive test = new Identical(function.parameters.single, nullPrimitive);

+ Primitive test = new ApplyBuiltinOperator(

+ BuiltinOperator.Identical,

+ <Primitive>[function.parameters.single, nullPrimitive]);

Expression newBody =

new LetCont.many(<Continuation>[returnFalse, originalBody],

@@ -270,7 +272,9 @@ class UnsugarVisitor extends RecursiveVisitor {

InteriorNode parent = node.parent;

IsTrue condition = node.condition;

Primitive t = trueConstant;

- Primitive i = new Identical(condition.value.definition, t);

+ Primitive i = new ApplyBuiltinOperator(

+ BuiltinOperator.Identical,

+ <Primitive>[condition.value.definition, t]);

LetPrim newNode = new LetPrim(t,

new LetPrim(i,

new Branch(new IsTrue(i),