Issue 12047046: Change new DateTime.fromString to DateTime.parse.

Issue 12047046: Change new DateTime.fromString to DateTime.parse. (Closed)

Created:
7 years, 11 months ago by floitsch

Modified:
7 years, 11 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change new DateTime.fromString to DateTime.parse. Committed: https://code.google.com/p/dart/source/detail?r=17550

Patch Set 2 : Add return type. #

Total comments: 4

Patch Set 3 : Address comments. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -47 lines)			Patch
M	samples/chat/dart_client/chat.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/core/date_time.dart	View	1 2	2 chunks	+3 lines, -11 lines	0 comments	Download
M	tests/corelib/date_time2_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/corelib/date_time3_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/date_time4_test.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/corelib/date_time7_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A	tests/corelib/date_time_parse_test.dart	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	tests/corelib/date_time_test.dart	View		15 chunks	+25 lines, -25 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/12047046/diff/2001/sdk/lib/core/date_time.dart File sdk/lib/core/date_time.dart (right): https://codereview.chromium.org/12047046/diff/2001/sdk/lib/core/date_time.dart#newcode197 sdk/lib/core/date_time.dart:197: * The function parses a subset of ISO ...

7 years, 11 months ago (2013-01-24 07:04:24 UTC) #3

floitsch

7 years, 11 months ago (2013-01-24 12:20:26 UTC) #4

https://codereview.chromium.org/12047046/diff/2001/sdk/lib/core/date_time.dart
File sdk/lib/core/date_time.dart (right):

https://codereview.chromium.org/12047046/diff/2001/sdk/lib/core/date_time.dar...
sdk/lib/core/date_time.dart:197: * The function parses a subset of ISO 8601.
Examples of accepted strings:
On 2013/01/24 07:04:24, Lasse Reichstein Nielsen wrote:
> Can't we do better than examples, e.g., give a grammar?

Added a TODO. I completely agree, but I don't have the time at the moment.

https://codereview.chromium.org/12047046/diff/2001/sdk/lib/core/date_time.dar...
sdk/lib/core/date_time.dart:211: //    - "2012-02-27 13:27:00"
On 2013/01/24 07:04:24, Lasse Reichstein Nielsen wrote:
> Remove this comment if it's duplicated in the method comment.

Done.

Expand Messages | Collapse Messages