Change new DateTime.fromString to DateTime.parse.

sdk/lib/core/date_time.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.core;
 
 /**
  * Deprecated class. Please use [DateTime] instead.
  */
 abstract class Date implements Comparable {
@@ skipping 38 matching lines @@
                     int minute = 0,
                     int second = 0,
                     int millisecond = 0]) {
     return
         new DateTime.utc(year, month, day, hour, minute, second, millisecond);
   }
 
   factory Date.now() => new DateTime.now();
 
   factory Date.fromString(String formattedString)
-      => new DateTime.fromString(formattedString);
+      => DateTime.parse(formattedString);
 
   factory Date.fromMillisecondsSinceEpoch(int millisecondsSinceEpoch,
                                           {bool isUtc: false}) {
     return new DateTime.fromMillisecondsSinceEpoch(millisecondsSinceEpoch,
                                                    isUtc: isUtc);
   }
 
   bool operator ==(DateTime other);
   bool operator <(DateTime other);
   bool operator <=(DateTime other);
@@ skipping 117 matching lines @@
   /**
    * Constructs a new [DateTime] instance with current date time value in the
    * local time zone.
    */
   // TODO(8042): This should be a redirecting constructor and not a factory.
   factory DateTime.now() { return new DateTime._now(); }
 
   /**
    * Constructs a new [DateTime] instance based on [formattedString].
    *
    * The function parses a subset of ISO 8601. Examples of accepted strings:

[Lasse Reichstein Nielsen, 2013/01/24 07:04:24]

Can't we do better than examples, e.g., give a grammar?

[floitsch, 2013/01/24 12:20:26]

Added a TODO. I completely agree, but I don't have the time at the moment.

    *
    * * `"2012-02-27 13:27:00"`
    * * `"2012-02-27 13:27:00.123456z"`
    * * `"20120227 13:27:00"`
    * * `"20120227T132700"`
    * * `"20120227"`
    * * `"+20120227"`
    * * `"2012-02-27T14Z"`
    * * `"-123450101 00:00:00 Z"`: in the year -12345.
    */
-  factory DateTime.fromString(String formattedString) {
+  static DateTime parse(String formattedString) {
     // Read in (a subset of) ISO 8601.
     // Examples:
     //    - "2012-02-27 13:27:00"

[Lasse Reichstein Nielsen, 2013/01/24 07:04:24]

Remove this comment if it's duplicated in the method comment.

[floitsch, 2013/01/24 12:20:26]

Done.

     //    - "2012-02-27 13:27:00.423z"
     //    - "20120227 13:27:00"
     //    - "20120227T132700"
     //    - "20120227"
     //    - "2012-02-27T14Z"
     //    - "-123450101 00:00:00 Z"  // In the year -12345.
     final RegExp re = new RegExp(
         r'^([+-]?\d?\d\d\d\d)-?(\d\d)-?(\d\d)'  // The day part.
         r'(?:[ T](\d\d)(?::?(\d\d)(?::?(\d\d)(.\d{1,6})?)?)? ?([zZ])?)?$');
     Match match = re.firstMatch(formattedString);
@@ skipping 255 matching lines @@
    * Returns the millisecond into the second [0...999].
    */
   external int get millisecond;
 
   /**
    * Returns the week day [MON..SUN]. In accordance with ISO 8601
    * a week starts with Monday which has the value 1.
    */
   external int get weekday;
 }