Issue 12045076: Second half of HTML json docs. This reads the json file and inserts the docs.

Issue 12045076: Second half of HTML json docs. This reads the json file and inserts the docs. (Closed)

Created:
7 years, 11 months ago by Andrei Mouravski

Modified:
7 years, 11 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Second half of HTML json docs. This reads the json file and inserts the docs. The format should match what was hand-written, but the order of annotations may have changed. This does not effect anything, but it's worth noting. Committed: https://code.google.com/p/dart/source/detail?r=17649

Patch Set 1 #

Patch Set 2 : Merged. #

Patch Set 3 : Line too long. #

Total comments: 8

Patch Set 4 : Code review changes. #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -29 lines)			Patch
M	sdk/lib/_internal/dartdoc/lib/dartdoc.dart	View	1 2 3	2 chunks	+17 lines, -1 line	0 comments	Download
M	tools/dom/docs/lib/docs.dart	View	1	2 chunks	+14 lines, -5 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 2 3	5 chunks	+37 lines, -5 lines	2 comments	Download
M	tools/dom/scripts/htmleventgenerator.py	View		5 chunks	+7 lines, -7 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 2 3	6 chunks	+11 lines, -7 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

blois

https://codereview.chromium.org/12045076/diff/5001/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/12045076/diff/5001/tools/dom/scripts/generator.py#newcode806 tools/dom/scripts/generator.py:806: html_json = json.load(open(json_path)) dom_json, unless it's only for dart:html. ...

7 years, 11 months ago (2013-01-25 18:49:13 UTC) #2

Andrei Mouravski

PTAL. https://codereview.chromium.org/12045076/diff/5001/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/12045076/diff/5001/tools/dom/scripts/generator.py#newcode806 tools/dom/scripts/generator.py:806: html_json = json.load(open(json_path)) On 2013/01/25 18:49:13, blois wrote: ...

7 years, 11 months ago (2013-01-25 19:11:51 UTC) #3

blois

lgtm https://codereview.chromium.org/12045076/diff/2002/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/12045076/diff/2002/tools/dom/scripts/generator.py#newcode16 tools/dom/scripts/generator.py:16: current_dir = os.path.dirname(__file__) should be private types (_current_dir, ...

7 years, 11 months ago (2013-01-25 19:16:32 UTC) #4

Andrei Mouravski

7 years, 11 months ago (2013-01-25 19:23:31 UTC) #5

Thanks! Submitting.

https://codereview.chromium.org/12045076/diff/2002/tools/dom/scripts/generato...
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/12045076/diff/2002/tools/dom/scripts/generato...
tools/dom/scripts/generator.py:16: current_dir = os.path.dirname(__file__)
On 2013/01/25 19:16:32, blois wrote:
> should be private types (_current_dir, etc).

Done.

Expand Messages | Collapse Messages