Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: tools/dom/docs/lib/docs.dart

Issue 12045076: Second half of HTML json docs. This reads the json file and inserts the docs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/docs/lib/docs.dart
diff --git a/tools/dom/docs/lib/docs.dart b/tools/dom/docs/lib/docs.dart
index 14200fcd4d67f0c609a10ddab663a5e3fefc6c6d..69d9854b4ca35d8a78ecc12d43b28667039101f6 100644
--- a/tools/dom/docs/lib/docs.dart
+++ b/tools/dom/docs/lib/docs.dart
@@ -28,7 +28,10 @@ const List<String> HTML_LIBRARY_NAMES = const ['dart:html',
* $interface_name: {
* comment: "$comment"
* members: {
- * $member: "$comment",
+ * $member: [
+ * $comment1,
+ * ...
+ * ],
* ...
* }
* },
@@ -92,14 +95,20 @@ Map _generateJsonFromLibraries(Compilation compilation) {
var membersJson = {};
for (var memberMirror in sortedMembers) {
var memberDomName = domNames(memberMirror)[0];
- var memberComment = computeComment(memberMirror);
- if (memberComment != null) {
+ var memberComment = computeUntrimmedCommentAsList(memberMirror);
+
+ // Remove interface name from Dom Name.
+ if (memberDomName.indexOf('.') >= 0) {
+ memberDomName = memberDomName.slice(memberDomName.indexOf('.') + 1);
+ }
+
+ if (!memberComment.isEmpty) {
membersJson.putIfAbsent(memberDomName, () => memberComment);
}
}
- var classComment = computeComment(classMirror);
- if (classComment != null) {
+ var classComment = computeUntrimmedCommentAsList(classMirror);
+ if (!classComment.isEmpty) {
classJson.putIfAbsent('comment', () => classComment);
}
if (!membersJson.isEmpty) {

Powered by Google App Engine
This is Rietveld 408576698