Get rid of unneeded Future.immediate() calls.

Get rid of unneeded Future.immediate() calls.

Future.then() will now implicitly wrap the callback result in a
future if it isn't one, so this manual wrapping can be removed.

Also take advantage of the fact that Future.immediate() is always
async now and remove some workarounds.

Finally, noticed there were two copies of the git-related code
floating around so killed the old one.

Committed: https://code.google.com/p/dart/source/detail?r=17519

[Bob Nystrom, 2013-01-23 18:45:57]

Yay making code cleaner!

[Alan Knight, 2013-01-24 00:03:20]

lgtm, one tiny style nit that's really just a matter of opinion.

https://codereview.chromium.org/12042053/diff/1/utils/pub/entrypoint.dart
File utils/pub/entrypoint.dart (right):

https://codereview.chromium.org/12042053/diff/1/utils/pub/entrypoint.dart#new...
utils/pub/entrypoint.dart:77: if (!exists) return;
Being fussy, but seeing as this isn't a void function it seems clearer to me to
explicitly say "return null" than just "return".

[Bob Nystrom, 2013-01-24 00:57:42]

Thanks!

https://codereview.chromium.org/12042053/diff/1/utils/pub/entrypoint.dart
File utils/pub/entrypoint.dart (right):

https://codereview.chromium.org/12042053/diff/1/utils/pub/entrypoint.dart#new...
utils/pub/entrypoint.dart:77: if (!exists) return;
On 2013/01/24 00:03:20, Alan Knight wrote:
> Being fussy, but seeing as this isn't a void function it seems clearer to me
to
> explicitly say "return null" than just "return".

The intent here is to exit the function and not exit with a value. You'll note
the following then() just has _ for the parameter, so this callback doesn't
actually return anything. So I figured "return" was closer to the original
intent.

Or, said another way, if this code didn't have to deal with async shenanigans,
this would just be a bare "return" so I figured I'd do that in the async form
too since I can.