Issue 12040059: Converting tests over to using event streams.

Issue 12040059: Converting tests over to using event streams. (Closed)

Created:
7 years, 11 months ago by blois

Modified:
7 years, 10 months ago

Reviewers:
Emily Fortuna, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Converting tests over to using event streams. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17735

Patch Set 1 : #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+304 lines, -463 lines)			Patch
M	pkg/unittest/lib/html_config.dart	View	2 chunks	+15 lines, -18 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	7 chunks	+18 lines, -34 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	7 chunks	+18 lines, -34 lines	0 comments	Download
M	tests/html/canvas_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/html/element_test.dart	View	4 chunks	+61 lines, -166 lines	0 comments	Download
M	tests/html/event_customevent_test.dart	View	1 chunk	+14 lines, -4 lines	0 comments	Download
M	tests/html/events_test.dart	View	1 chunk	+11 lines, -9 lines	0 comments	Download
M	tests/html/form_data_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/html/history_test.dart	View	2 chunks	+2 lines, -12 lines	0 comments	Download
M	tests/html/indexeddb_1_test.dart	View	8 chunks	+26 lines, -26 lines	0 comments	Download
M	tests/html/indexeddb_2_test.dart	View	4 chunks	+13 lines, -13 lines	0 comments	Download
M	tests/html/indexeddb_3_test.dart	View	6 chunks	+17 lines, -17 lines	0 comments	Download
M	tests/html/indexeddb_4_test.dart	View	4 chunks	+15 lines, -15 lines	0 comments	Download
M	tests/html/inner_frame_test.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/html/js_interop_1_test.dart	View	1 chunk	+10 lines, -9 lines	0 comments	Download
M	tests/html/keyboard_event_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/native_gc_test.dart	View	5 chunks	+8 lines, -6 lines	0 comments	Download
M	tests/html/postmessage_structured_test.dart	View	3 chunks	+40 lines, -45 lines	1 comment	Download
M	tests/html/transferables_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/url_test.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/html/wheelevent_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/xhr_cross_origin_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/xhr_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/docs/docs.json	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/src/KeyboardEventController.dart	View	4 chunks	+16 lines, -12 lines	0 comments	Download
M	tools/dom/src/_HttpRequestUtils.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
D	tools/dom/src/_Testing.dart	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

7 years, 10 months ago (2013-01-28 23:15:18 UTC) #2

lgtm

https://codereview.chromium.org/12040059/diff/4001/tests/html/postmessage_str...
File tests/html/postmessage_structured_test.dart (right):

https://codereview.chromium.org/12040059/diff/4001/tests/html/postmessage_str...
tests/html/postmessage_structured_test.dart:97: if (data is String) return;   
// Messages from unit test protocol.
delete one space here and you can get this line back to 80 char. :-)

Expand Messages | Collapse Messages