Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1203783004: Make use of test_flushAstStructures in analysis server. (Closed)

Created:
5 years, 6 months ago by Paul Berry
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix analyzer dependency, remove unused imports, rename method to match previous CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 3 chunks +3 lines, -19 lines 0 comments Download
M pkg/analysis_server/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/update_content_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
To be applied after landing https://codereview.chromium.org/1210603002/ and publishing a new version of the analyzer package.
5 years, 6 months ago (2015-06-24 16:50:20 UTC) #2
Brian Wilkerson
LGTM
5 years, 6 months ago (2015-06-24 16:58:28 UTC) #3
Paul Berry
5 years, 6 months ago (2015-06-24 21:04:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
921a5229fa2a7d20cad8b36d02a1428420ad04e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698