Issue 12036071: Fixing analyzer issues in DOM libs.

Issue 12036071: Fixing analyzer issues in DOM libs. (Closed)

Created:
7 years, 11 months ago by blois

Modified:
7 years, 10 months ago

Reviewers:
Lasse Reichstein Nielsen, floitsch

CC:
reviews_dartlang.org, Emily Fortuna

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing bunch of analyzer issues in DOM libs. Basic changes: - missing references to collections-dev, - missing implementation of abstract methods - Couple of incorrect generic arguments (which cause ugly dart2js warnings for users) - Removed more references to Collections BUG= Committed: https://code.google.com/p/dart/source/detail?r=17582

Patch Set 1 #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+934 lines, -333 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	104 chunks	+377 lines, -136 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	104 chunks	+377 lines, -136 lines	0 comments	Download
M	sdk/lib/html/html_common/filtered_element_list.dart	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	sdk/lib/html/html_common/html_common.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/html_common/html_common_dart2js.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	19 chunks	+67 lines, -24 lines	1 comment	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	19 chunks	+67 lines, -24 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/svg_dart2js.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/dartium/svg_dartium.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/dartium/web_audio_dartium.darttemplate	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	3 chunks	+10 lines, -4 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Node.darttemplate	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/dom/templates/immutable_list_mixin.darttemplate	View	3 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/12036071/diff/1/sdk/lib/svg/dart2js/svg_dart2js.dart File sdk/lib/svg/dart2js/svg_dart2js.dart (right): https://codereview.chromium.org/12036071/diff/1/sdk/lib/svg/dart2js/svg_dart2js.dart#newcode3684 sdk/lib/svg/dart2js/svg_dart2js.dart:3684: new ReversedListView<Length>(this, 0, null); We should probably make ...

7 years, 11 months ago (2013-01-24 06:55:45 UTC) #2

floitsch

7 years, 10 months ago (2013-01-29 16:46:36 UTC) #3

Message was sent while issue was closed.

On 2013/01/24 06:55:45, Lasse Reichstein Nielsen wrote:
> lgtm
> 
>
https://codereview.chromium.org/12036071/diff/1/sdk/lib/svg/dart2js/svg_dart2...
> File sdk/lib/svg/dart2js/svg_dart2js.dart (right):
> 
>
https://codereview.chromium.org/12036071/diff/1/sdk/lib/svg/dart2js/svg_dart2...
> sdk/lib/svg/dart2js/svg_dart2js.dart:3684: new ReversedListView<Length>(this,
0,
> null);
> We should probably make the class private, and have an
> IterableMixinWorkaround.reverseList method.

I'm trying to remove references to collection-dev (except in core and
collection).
I will remove the imports (and fix the references), so please don't readd the
import.

Expand Messages | Collapse Messages