Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 12036065: Make pub use the SDK's "version" file for its version. (Closed)

Created:
7 years, 11 months ago by Bob Nystrom
Modified:
7 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make pub use the SDK's "version" file for its version. This includes pub's own version and the implied version of SDK packages. I also added a little test that verifies that pub can parse the actual version file generated with the SDK. BUG=5906, 6173, 7837 Committed: https://code.google.com/p/dart/source/detail?r=17512

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment regex. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -61 lines) Patch
M utils/pub/pub.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M utils/pub/sdk.dart View 1 2 chunks +23 lines, -4 lines 0 comments Download
M utils/tests/pub/install/pub_install_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/install/sdk/check_out_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M utils/tests/pub/install/sdk/check_out_transitive_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M utils/tests/pub/pub_test.dart View 7 chunks +36 lines, -23 lines 0 comments Download
M utils/tests/pub/pub_uploader_test.dart View 1 chunk +12 lines, -7 lines 0 comments Download
A utils/tests/pub/real_version_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 3 chunks +7 lines, -14 lines 0 comments Download
M utils/tests/pub/update/pub_update_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
Thank you!
7 years, 11 months ago (2013-01-23 23:08:19 UTC) #1
Emily Fortuna
lgtm, with a suggestion https://codereview.chromium.org/12036065/diff/1/utils/pub/sdk.dart File utils/pub/sdk.dart (right): https://codereview.chromium.org/12036065/diff/1/utils/pub/sdk.dart#newcode14 utils/pub/sdk.dart:14: final _versionPattern = new RegExp(r'^(\d+)\.(\d+)\.(\d+)\.(\d+)(.*)$'); ...
7 years, 11 months ago (2013-01-23 23:15:19 UTC) #2
Bob Nystrom
7 years, 11 months ago (2013-01-23 23:20:35 UTC) #3
Message was sent while issue was closed.
Thanks!

https://codereview.chromium.org/12036065/diff/1/utils/pub/sdk.dart
File utils/pub/sdk.dart (right):

https://codereview.chromium.org/12036065/diff/1/utils/pub/sdk.dart#newcode14
utils/pub/sdk.dart:14: final _versionPattern = new
RegExp(r'^(\d+)\.(\d+)\.(\d+)\.(\d+)(.*)$');
On 2013/01/23 23:15:19, Emily Fortuna wrote:
> regex-licious! Want to put a comment above this just explaining in words what
a
> version pattern is expected to look like for posterity? :-)

Done.

Powered by Google App Engine
This is Rietveld 408576698