Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: utils/tests/pub/test_pub.dart

Issue 12036065: Make pub use the SDK's "version" file for its version. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Comment regex. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/tests/pub/real_version_test.dart ('k') | utils/tests/pub/update/pub_update_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/test_pub.dart
diff --git a/utils/tests/pub/test_pub.dart b/utils/tests/pub/test_pub.dart
index 2ded719bb7a4f58d557eedb971ee80c9b2b4a8d4..056640111d63b252530c9b44ae0d97c9782cef2e 100644
--- a/utils/tests/pub/test_pub.dart
+++ b/utils/tests/pub/test_pub.dart
@@ -432,7 +432,7 @@ final String appPath = "myapp";
/// to the sandbox directory.
final String packagesPath = "$appPath/packages";
-/// The type for callbacks that will be fired during [runPub]. Takes the
+/// The type for callbacks that will be fired during [schedulePub]. Takes the
/// sandbox directory as a parameter.
typedef Future _ScheduledEvent(Directory parentDir);
@@ -538,15 +538,6 @@ void schedulePub({List args, Pattern output, Pattern error,
});
}
-/// A shorthand for [schedulePub] and [run] when no validation needs to be done
-/// after Pub has been run.
-///
-/// Any futures in [args] will be resolved before the process is started.
-void runPub({List args, Pattern output, Pattern error, int exitCode: 0}) {
- schedulePub(args: args, output: output, error: error, exitCode: exitCode);
- _run();
-}
-
/// Starts a Pub process and returns a [ScheduledProcess] that supports
/// interaction with that process.
///
@@ -786,16 +777,18 @@ abstract class Descriptor {
/// loads the contents of the descriptor itself.
InputStream load(List<String> path);
- /// Schedules the directory to be created before Pub is run with [runPub].
- /// The directory will be created relative to the sandbox directory.
+ /// Schedules the directory to be created before Pub is run with
+ /// [schedulePub]. The directory will be created relative to the sandbox
+ /// directory.
// TODO(nweiz): Use implicit closurization once issue 2984 is fixed.
void scheduleCreate() => _schedule((dir) => this.create(dir));
/// Schedules the file or directory to be deleted recursively.
void scheduleDelete() => _schedule((dir) => this.delete(dir));
- /// Schedules the directory to be validated after Pub is run with [runPub].
- /// The directory will be validated relative to the sandbox directory.
+ /// Schedules the directory to be validated after Pub is run with
+ /// [schedulePub]. The directory will be validated relative to the sandbox
+ /// directory.
void scheduleValidate() => _schedule((parentDir) => validate(parentDir.path));
/// Asserts that the name of the descriptor is a [String] and returns it.
« no previous file with comments | « utils/tests/pub/real_version_test.dart ('k') | utils/tests/pub/update/pub_update_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698