Issue 12035037: Removing @DocsEditable from classes we have darttemplates for.

Issue 12035037: Removing @DocsEditable from classes we have darttemplates for. (Closed)

Created:
7 years, 11 months ago by blois

Modified:
7 years, 11 months ago

Reviewers:
Andrei Mouravski

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Removing @DocsEditable from classes we have darttemplates for. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17436

Patch Set 1 #

Total comments: 4

Created: 7 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+8251 lines, -8334 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	397 chunks	+2445 lines, -2482 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	433 chunks	+2952 lines, -2980 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	40 chunks	+129 lines, -132 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	38 chunks	+130 lines, -132 lines	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	180 chunks	+1019 lines, -1032 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	135 chunks	+1308 lines, -1310 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View	24 chunks	+111 lines, -113 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View	30 chunks	+149 lines, -150 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 chunk	+6 lines, -2 lines	2 comments	Download
M	tools/dom/templates/dart2js_impl.darttemplate	View	1 chunk	+1 line, -1 line	2 comments	Download
M	tools/dom/templates/html/dartium/dart_implementation.darttemplate	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Andrei Mouravski

2 things. https://codereview.chromium.org/12035037/diff/1/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/12035037/diff/1/tools/dom/scripts/generator.py#newcode803 tools/dom/scripts/generator.py:803: annotations.append('@DocsEditable'); Can you make this prepend so ...

7 years, 11 months ago (2013-01-22 22:49:10 UTC) #2

blois

https://codereview.chromium.org/12035037/diff/1/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/12035037/diff/1/tools/dom/scripts/generator.py#newcode803 tools/dom/scripts/generator.py:803: annotations.append('@DocsEditable'); On 2013/01/22 22:49:10, Andrei Mouravski wrote: > Can ...

7 years, 11 months ago (2013-01-22 22:58:50 UTC) #3

lgtm

Expand Messages | Collapse Messages