tools/dom/scripts/generator.py - Issue 12035037: Removing @DocsEditable from classes we have darttemplates for.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/generator.py

Issue 12035037: Removing @DocsEditable from classes we have darttemplates for. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/web_audio/dartium/web_audio_dartium.dart ('k') | tools/dom/templates/dart2js_impl.darttemplate » ('j') | tools/dom/templates/dart2js_impl.darttemplate » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/scripts/generator.py

diff --git a/tools/dom/scripts/generator.py b/tools/dom/scripts/generator.py

index 8fa13f64ba2b4eb14342eff5adca411ce5d162e6..738cd1dac63ffda3124309a3f32b8024b12198fd 100644

--- a/tools/dom/scripts/generator.py

+++ b/tools/dom/scripts/generator.py

@@ -796,8 +796,12 @@ def FindCommonAnnotations(interface_name, member_name=None):

else:

key = interface_name

- annotations = ["@DocsEditable",

- "@DomName('" + key + "')",]

+ annotations = ["@DomName('" + key + "')",]

+ # Only add this for members, so we don't add DocsEditable to templated classes

+ # (they get it from the default class template)

+ if member_name:

+ annotations.append('@DocsEditable');

Andrei Mouravski 2013/01/22 22:49:10 Can you make this prepend so that the diff is near

blois 2013/01/22 22:58:50 If the order of attributes is not necessary, then

if (dart_annotations.get(key) != None):

annotations.extend(dart_annotations.get(key))