Issue 12033036: Fix native lookup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12033036: Fix native lookup. (Closed)

Created:
7 years, 11 months ago by srdjan

Modified:
7 years, 11 months ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix native lookup. Fix external byte arrays. Committed: https://code.google.com/p/dart/source/detail?r=17478

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -88 lines)			Patch
M	runtime/lib/byte_array.cc	View	1 2 3	5 chunks	+26 lines, -9 lines	0 comments	Download
M	runtime/lib/byte_array.dart	View	1 2 3	33 chunks	+45 lines, -77 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/os.h	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

srdjan

Also added fixes to external byte arrays (range check and clearing).

7 years, 11 months ago (2013-01-23 01:05:51 UTC) #4

Still LGTM. -ip